From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 32741805E for <dev@dpdk.org>; Wed, 17 Dec 2014 11:46:36 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 17 Dec 2014 02:46:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,593,1413270000"; d="scan'208";a="649056840" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.28]) by fmsmga002.fm.intel.com with SMTP; 17 Dec 2014 02:46:11 -0800 Received: by (sSMTP sendmail emulation); Wed, 17 Dec 2014 10:46:10 +0025 Date: Wed, 17 Dec 2014 10:46:09 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Message-ID: <20141217104609.GC9184@bricha3-MOBL3> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05DD6DFE@BPXM14GP.gisp.nec.co.jp> <4299912.gJckj7WjkF@xps13> <20141217103815.GA9184@bricha3-MOBL3> <2481080.vLqlGC2Goh@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2481080.vLqlGC2Goh@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com> Subject: Re: [dpdk-dev] [PATCH] mk: fix link to combined library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Dec 2014 10:46:37 -0000 On Wed, Dec 17, 2014 at 11:43:51AM +0100, Thomas Monjalon wrote: > 2014-12-17 10:38, Bruce Richardson: > > On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > > > 2014-12-11 02:54, Hiroshi Shimamoto: > > > > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > > > > > > > The application should be linked to the single combined library in the > > > > condition that both of CONFIG_RTE_BUILD_COMBINE_LIB and > > > > CONFIG_RTE_BUILD_SHARED_LIB are enabled. > > > > > > > > The current makefile generates an application that links to each library. > > > > This patch fixes to link the single library. > > > > > > > > Before > > > > $ ldd x86_64-ivshmem-linuxapp-gcc/app/test > > > > linux-vdso.so.1 => (0x00007fff232a1000) > > > > librte_distributor.so => not found > > > > librte_kni.so => not found > > > > librte_ivshmem.so => not found > > > > librte_pipeline.so => not found > > > > librte_table.so => not found > > > > librte_port.so => not found > > > > librte_timer.so => not found > > > > librte_hash.so => not found > > > > librte_lpm.so => not found > > > > librte_power.so => not found > > > > librte_acl.so => not found > > > > librte_meter.so => not found > > > > librte_sched.so => not found > > > > libm.so.6 => /lib64/libm.so.6 (0x00007fc638020000) > > > > librt.so.1 => /lib64/librt.so.1 (0x00007fc637e18000) > > > > librte_kvargs.so => not found > > > > librte_mbuf.so => not found > > > > librte_ip_frag.so => not found > > > > libethdev.so => not found > > > > librte_malloc.so => not found > > > > librte_mempool.so => not found > > > > librte_ring.so => not found > > > > librte_eal.so => not found > > > > librte_cmdline.so => not found > > > > librte_cfgfile.so => not found > > > > librte_pmd_bond.so => not found > > > > libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fc637bfe000) > > > > libdl.so.2 => /lib64/libdl.so.2 (0x00007fc6379fa000) > > > > libintel_dpdk.so => not found > > > > libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fc6377dd000) > > > > libc.so.6 => /lib64/libc.so.6 (0x00007fc63741c000) > > > > /lib64/ld-linux-x86-64.so.2 (0x00007fc638330000) > > > > > > > > After > > > > $ ldd x86_64-ivshmem-linuxapp-gcc/app/test > > > > linux-vdso.so.1 => (0x00007fffb79fe000) > > > > librt.so.1 => /lib64/librt.so.1 (0x00007f0d8a971000) > > > > libm.so.6 => /lib64/libm.so.6 (0x00007f0d8a66f000) > > > > libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f0d8a458000) > > > > libdl.so.2 => /lib64/libdl.so.2 (0x00007f0d8a254000) > > > > libintel_dpdk.so => not found > > > > libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f0d8a037000) > > > > libc.so.6 => /lib64/libc.so.6 (0x00007f0d89c76000) > > > > /lib64/ld-linux-x86-64.so.2 (0x00007f0d8ab82000) > > > > > > > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > > > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> > > > > > > It is what I suggested to Sergio: > > > http://dpdk.org/ml/archives/dev/2014-December/009116.html > > > > > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > > > > > Applied > > > > > > Thanks > > > > None of the example apps are compiling for me today, and git bisect indicates that > > this patch is the culprit. I'm investigating, but if flagging it here in case > > someone else finds a fix faster than I do. > > Yes, Marvin already sent a patch: Yes, so I see, Sergio just pointed it out to me here too! I'll ack that one for you. /Bruce > http://dpdk.org/dev/patchwork/patch/2049/ > > > The error is due to the libraries being missing on the link command, with the > > out-of-the-box configuration i.e. individual static libs. > > Sorry, I forgot to test this basic case after applying the patch. > > -- > Thomas