* [dpdk-dev] [PATCH] fix bug can not build example application for missing link library
@ 2014-12-17 9:20 Marvin Liu
2014-12-17 10:47 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Marvin Liu @ 2014-12-17 9:20 UTC (permalink / raw)
To: dev
From: Yong Liu <yong.liu@intel.com>
main.o: In function `rte_pktmbuf_free':
main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
Signed-off-by: Marvin liu <yong.liu@intel.com>
---
mk/rte.app.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 5fc3118..b51d814 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -61,7 +61,7 @@ ifeq ($(NO_AUTOLIBS),)
LDLIBS += --whole-archive
-ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
LDLIBS += -lrte_distributor
@@ -129,7 +129,7 @@ endif
LDLIBS += --start-group
-ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)
LDLIBS += -lrte_kvargs
@@ -251,7 +251,7 @@ build: _postbuild
exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
-ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
LDLIBS += -l$(RTE_LIBNAME)
endif
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fix bug can not build example application for missing link library
2014-12-17 9:20 [dpdk-dev] [PATCH] fix bug can not build example application for missing link library Marvin Liu
@ 2014-12-17 10:47 ` Bruce Richardson
2014-12-17 11:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2014-12-17 10:47 UTC (permalink / raw)
To: Marvin Liu; +Cc: dev
On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote:
> From: Yong Liu <yong.liu@intel.com>
>
> main.o: In function `rte_pktmbuf_free':
> main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
>
> Signed-off-by: Marvin liu <yong.liu@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> mk/rte.app.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 5fc3118..b51d814 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -61,7 +61,7 @@ ifeq ($(NO_AUTOLIBS),)
>
> LDLIBS += --whole-archive
>
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>
> ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
> LDLIBS += -lrte_distributor
> @@ -129,7 +129,7 @@ endif
>
> LDLIBS += --start-group
>
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>
> ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)
> LDLIBS += -lrte_kvargs
> @@ -251,7 +251,7 @@ build: _postbuild
>
> exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
>
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
> LDLIBS += -l$(RTE_LIBNAME)
> endif
>
> --
> 1.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fix bug can not build example application for missing link library
2014-12-17 10:47 ` Bruce Richardson
@ 2014-12-17 11:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-12-17 11:00 UTC (permalink / raw)
To: Marvin Liu; +Cc: dev
2014-12-17 10:47, Bruce Richardson:
> On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote:
> > From: Yong Liu <yong.liu@intel.com>
> >
> > main.o: In function `rte_pktmbuf_free':
> > main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
> >
> > Signed-off-by: Marvin liu <yong.liu@intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied
Thanks for the quick fix
--
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-17 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 9:20 [dpdk-dev] [PATCH] fix bug can not build example application for missing link library Marvin Liu
2014-12-17 10:47 ` Bruce Richardson
2014-12-17 11:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).