From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 1C5F71F5
 for <dev@dpdk.org>; Thu, 18 Dec 2014 21:54:46 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Y1i5q-00014m-M5; Thu, 18 Dec 2014 15:54:44 -0500
Date: Thu, 18 Dec 2014 15:54:41 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Message-ID: <20141218205441.GF18008@hmsreliant.think-freely.org>
References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
 <1418902316-30266-1-git-send-email-nhorman@tuxdriver.com>
 <533710CFB86FA344BFBF2D6802E60286CA0ECB@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CA0ECB@SHSMSX101.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] xenvirt: Fix build break on
 cmdline_parse_etheraddr call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2014 20:54:46 -0000

On Thu, Dec 18, 2014 at 01:45:54PM +0000, Qiu, Michael wrote:
> Hi Neil,
> 
> I think if you could add the commit author in the cc list will be better.
> 
The commit author is me, and its recorded by the Signed-off line, as well as the
Authorship tag in git.  Not really sure what you're driving at here.

> Because this could let him know about his code's issue and he is the
> always the best person to review the patch.
> 
Yes, Git already does that, as noted above.

Neil


> Thanks,
> Michael
> 
> On 2014/12/18 19:32, Neil Horman wrote:
> > Back in:
> >
> > commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
> > Author: Alan Carew <alan.carew@intel.com>
> > Date:   Fri Dec 5 15:19:07 2014 +0100
> >
> >     cmdline: fix overflow on bsd
> >
> > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt.  This
> > patch makes the needed correction to avoid a build break
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Thomas Monjalon <thomas.monjalon@6wind.com>
> > CC: Olivier Matz <olivier.matz@6wind.com>
> >
> > ---
> > Change notes
> >
> > v2: Changed sizeof(struct ether_addr) to sizeof(dict->addr)
> > ---
> >  lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> > index 6555ec5..04e30c9 100644
> > --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> > +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> > @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,
> >  		if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,
> >  				sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {
> >  			if (cmdline_parse_etheraddr(NULL,
> > -							pair[1],
> > -							&dict->addr) < 0) {
> > +						    pair[1],
> > +						    &dict->addr,
> > +						    sizeof(dict->addr)) < 0) {
> >  				RTE_LOG(ERR, PMD,
> >  					"Invalid %s device ether address\n",
> >  					name);
> 
>