From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 84A5A282
 for <dev@dpdk.org>; Tue, 23 Dec 2014 16:50:37 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Y3Rj6-0007M7-BO; Tue, 23 Dec 2014 10:50:30 -0500
Date: Tue, 23 Dec 2014 10:50:23 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Message-ID: <20141223155023.GF31876@hmsreliant.think-freely.org>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-1-git-send-email-nhorman@tuxdriver.com>
 <91383E96CE459D47BCE92EFBF5CE73B004F210D1@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F210D1@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] compat: Add infrastructure to support
 symbol versioning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Dec 2014 15:50:37 -0000

On Tue, Dec 23, 2014 at 01:27:32PM +0000, Gonzalez Monroy, Sergio wrote:
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Monday, December 22, 2014 8:24 PM
> > +++ b/lib/librte_compat/Makefile
> >[...]
> > +
> > +include $(RTE_SDK)/mk/rte.vars.mk
> > +
> > +
> > +# install includes
> > +SYMLINK-y-include := rte_compat.h
> > +
> > +include $(RTE_SDK)/mk/rte.lib.mk
> >
> I just realized that we can avoid doing the _INSTALL change below if we include
> mk/rte_install.mk instead of mk/rte_lib.mk, as it is done in librte_net.
> 
> Regards,
> Sergio
> 
But doing so limits the compat directory to only install headers, correct? I'm
ok with that mind you, just need to keep it in mind if we ever add any sort of
compatibility code there.

Neil

> > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index 81bf8e1..cbd439b 100644
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -40,10 +40,17 @@ VPATH += $(SRCDIR)
> > [...]
> > +
> >  _BUILD = $(LIB)
> > -_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y)
> > $(RTE_OUTPUT)/lib/$(LIB)
> > +_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) ifneq ($(LIB),)
> > +_INSTALL += $(RTE_OUTPUT)/lib/$(LIB) endif
> >  _CLEAN = doclean
> > 
> >  .PHONY: all
> > --
> > 1.9.3
> 
>