From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 47A982AB
 for <dev@dpdk.org>; Tue, 23 Dec 2014 16:51:08 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Y3Rjf-0007O0-H5; Tue, 23 Dec 2014 10:51:05 -0500
Date: Tue, 23 Dec 2014 10:50:58 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Message-ID: <20141223155058.GG31876@hmsreliant.think-freely.org>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-3-git-send-email-nhorman@tuxdriver.com>
 <91383E96CE459D47BCE92EFBF5CE73B004F210AA@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F210AA@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] Add library version extenstion
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Dec 2014 15:51:08 -0000

On Tue, Dec 23, 2014 at 01:05:16PM +0000, Gonzalez Monroy, Sergio wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman
> > Sent: Monday, December 22, 2014 8:24 PM
> >
> > a/mk/rte.lib.mk b/mk/rte.lib.mk index 7949254..ad058b5 100644
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -166,9 +171,11 @@ endif
> >  # install lib in $(RTE_OUTPUT)/lib
> >  #
> >  $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
> > +	$(eval LIBSONAME := $(basename $(LIB)))
> >  	@echo "  INSTALL-LIB $(LIB)"
> >  	@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
> >  	$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
> > +	$(Q)ln -s -f $(RTE_OUTPUT)/lib/$(LIB)
> > $(RTE_OUTPUT)/lib/$(LIBSONAME)
> > 
> Sorry Neil, I missed this before.
> We probably only want to do symbolic links for shared libs. At the moment it creates lots of unwanted links for static libs too.
> Also, I would suggest to do relative symbolic links instead.
> 
Ack, will update
Neil

> Regards,
> Sergio
> 
> > --
> > 1.9.3
> 
>