From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Cc: dev@dpdk.org, andrey.chilikin@intel.com
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove versioning of ethdev filter control function
Date: Tue, 27 Feb 2018 14:45:14 +0100 [thread overview]
Message-ID: <2014327.T8y74eV2j1@xps> (raw)
In-Reply-To: <a199e23c-fae6-7e77-016e-c099e6ad3b2b@intel.com>
27/02/2018 12:01, Ferruh Yigit:
> On 2/27/2018 10:29 AM, Kirill Rybalchenko wrote:
> > In 18.02 release the ABI of ethdev component was changed.
> > To keep compatibility with previous versions of the library
> > the versioning of rte_eth_dev_filter_ctrl function was implemented.
> > As soon as deprecation note was issued in 18.02 release, there is
> > no need to keep compatibility with previous versions.
> > Remove the versioning of rte_eth_dev_filter_ctrl function.
> >
> > Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > ---
> > lib/librte_ether/rte_ethdev.c | 155 +-----------------------------------------
>
> Hi Kirill,
>
> You need to update .map file and removed deprecation notice in this patch.
And bump the ABI version in Makefile and release notes.
next prev parent reply other threads:[~2018-02-27 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 10:29 Kirill Rybalchenko
2018-02-27 11:01 ` Ferruh Yigit
2018-02-27 13:45 ` Thomas Monjalon [this message]
2018-02-27 14:18 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
2018-03-07 17:17 ` Ferruh Yigit
2018-03-07 17:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2014327.T8y74eV2j1@xps \
--to=thomas@monjalon.net \
--cc=andrey.chilikin@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kirill.rybalchenko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).