From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6F6B22C8 for ; Tue, 27 Feb 2018 14:45:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0CF0A2105A; Tue, 27 Feb 2018 08:45:16 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 27 Feb 2018 08:45:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LAnMPX+3cbR/CSHhc+4LQmwFi2 AsJ9PuOXhoDks4e18=; b=Hl3EatjQ9csaxD037awaTWg4kVmmQ9FwwzxrMrSYhi LrGcT91LyIq7vwvo4XJjWmhTFd/iOtlLbcjrzNouRg/xaZ4OTtb92cEPd+7xv7V8 CUqDjoYL2iswgiprrWUDS1MH2zBpMGzAiJq4S/xLf5CrbmCJQ5Dnuz+Q04iDPUIO E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LAnMPX +3cbR/CSHhc+4LQmwFi2AsJ9PuOXhoDks4e18=; b=YiTFUK9zwFojc0TxCKuBIP DGdnmwk9D1wegR6c6xbLISO4PaZj1g1Ci/OHxC4cgZYHmhSiVIWuHBCp5jwj+6Iy bmV8q/YpytdcydhYF3dIQHrBsHWMB1wSMdDcwhEBUKOQ/09tV57jNe9BQU/JV0eo roMi5KFPR4552clDHLLwZ7Rv1IhJ9sjNZ0vKL0FIQEOTXl034eo2NmNTzmpkVTCG igZH87LJR6e0qtOrR5gaILp2jQwAKQTMbEZun4bIwCelyArKjlLvtiBjx6yZPY19 LRDS3TpgnN1X9ni/mJXs/Jw5l+8Vxhu1kDXnKhGKK2Gh0lNe/FN7US+eirQDEtVg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5CB9224513; Tue, 27 Feb 2018 08:45:15 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Kirill Rybalchenko Cc: dev@dpdk.org, andrey.chilikin@intel.com Date: Tue, 27 Feb 2018 14:45:14 +0100 Message-ID: <2014327.T8y74eV2j1@xps> In-Reply-To: References: <1519727393-138815-1-git-send-email-kirill.rybalchenko@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: remove versioning of ethdev filter control function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 13:45:16 -0000 27/02/2018 12:01, Ferruh Yigit: > On 2/27/2018 10:29 AM, Kirill Rybalchenko wrote: > > In 18.02 release the ABI of ethdev component was changed. > > To keep compatibility with previous versions of the library > > the versioning of rte_eth_dev_filter_ctrl function was implemented. > > As soon as deprecation note was issued in 18.02 release, there is > > no need to keep compatibility with previous versions. > > Remove the versioning of rte_eth_dev_filter_ctrl function. > > > > Signed-off-by: Kirill Rybalchenko > > --- > > lib/librte_ether/rte_ethdev.c | 155 +----------------------------------------- > > Hi Kirill, > > You need to update .map file and removed deprecation notice in this patch. And bump the ABI version in Makefile and release notes.