From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3FD1A052A; Mon, 25 Jan 2021 13:37:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B73A140E6A; Mon, 25 Jan 2021 13:37:47 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id DC5EF140E54; Mon, 25 Jan 2021 13:37:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 2D9E6CAE; Mon, 25 Jan 2021 07:37:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 25 Jan 2021 07:37:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Bhq9vTwqCKBBQLrfot8VXSsgMsoWoZ4pMDmgh4GEuEA=; b=jSwz7ki1933KIzYn coq8bAgP1T/pu9vGgrHOmXxkqWJf2XQRw1lWjXwzHFULxBuerg7VtSge1eYFpzdN GMMC3cmim08eefhkCh5Ls4D11aERcAKaa1hhxuBi6NsB8kyjt2dAFefoTMUzlju2 LB053f07oS9qG6lzi11W0XdgezJZkZH2HMMr+aV/1ZC/ltEFLd4H5O0wkk8OsREJ SYk0N2ndn086beMOdvbmtqjg23xJfaSAnxiXNArxHR8WAriahhp/YezLe7DwnQZ/ n5MRFnMxWYBQ+G6i9UmOLlX6difJKJ0RTVrksDRlxbDyqYWyDRNo6kQehVWguoWD dmIQ+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Bhq9vTwqCKBBQLrfot8VXSsgMsoWoZ4pMDmgh4GEu EA=; b=Zi3flzfI/hhjMu3+DJ1HM24wnuQ8QNqzH5P8NkIYLRFnhbiIUjoCpODET s4RxuJZhnoHr50XkslACUBOjVp7/7yGc2KgY+mYzapP1cQ0XdpLwTAodBCMHgfpQ M7FJwdKzA1BQWYzjZjW1wrLWc044QmSbR4RHJ6igkNk/oPU+gDvYrd/RT1ntfTPY TfdLgv0iFmtU2AFEAMKZG5Owh03dGiVPNNij3M0NXfRHfIXflb2+TBy70utoTTWb JmMqTyB34BUkL7ORNnADM5qijdfv1EjBoSxEY7HNxSxAYW/A3Lh2ACVPlDVbjSMx y+8TmjN95wb9jV4zbmcLFv6ZvmKHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B009240057; Mon, 25 Jan 2021 07:37:42 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Anatoly Burakov , Ferruh Yigit , Liron Himi , Stephen Hemminger , Andrew Rybchenko Date: Mon, 25 Jan 2021 13:37:40 +0100 Message-ID: <201448393.hYmQimzCso@thomas> In-Reply-To: References: <20210122175804.772207-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] ethdev: fix handling of close failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2021 10:13, Andrew Rybchenko: > On 1/22/21 8:58 PM, Thomas Monjalon wrote: > > If a failure happens when closing a port, > > it was unnecessarily failing again in the function eth_err(), > > because of a check against HW removal cause. > > Indeed there is a big chance the port is released at this point. > > Given the port is in the middle (or at the end) of a close process, > > checking the error cause by accessing the port is a non-sense. > > The error check is replaced by a simple return in the close function. > > > > Bugzilla ID: 624 > > Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error") > > Cc: stable@dpdk.org > > > > Reported-by: Anatoly Burakov > > Signed-off-by: Thomas Monjalon > > Acked-by: Andrew Rybchenko Applied