From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 062E45A76
 for <dev@dpdk.org>; Tue, 20 Jan 2015 18:10:18 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id et14so46941004pad.1
 for <dev@dpdk.org>; Tue, 20 Jan 2015 09:10:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=+EKdcUdXwiN15S4bPHjin+Gs8nYaOQcx8pUohX2ddfs=;
 b=BsU6mFw9s9SXHcJTVbCT9i03OTvh/+Xq1Z6iGd4V+xIOmUqaS6k70BETgzV2RrAon0
 tsHzve4ZfsAxx4ysjkThiGPIUUnob3UlYnOgl3F01SYbroFIKWEYBtaVIYXGOMcIfP5R
 SF0Rif59Mi5jz/XBM5smlPCnJS6nF0DltYANsdMerqYsLIsGZhTjEofa5pKokJ5/9WpS
 OO2IayUIzp3uh6w806gK7lP+vuQYvd6q4hFqOKWyDRW6y/NfFHZgvxzAfllzeg+MnoVQ
 dchm3GgJgEPgW9AkBRKSPqQxJWfucRln5FWcUuMWiTCwG8Pn0cw203t9uzVZ5eofZZuW
 sTZw==
X-Gm-Message-State: ALoCoQmHvDNH6DNhg3KDWhsqIP0oCPqCYocOv4+L0/WwzouSDhNRqO7xv+Bok8lZVeFA2ado7vHJ
X-Received: by 10.68.137.98 with SMTP id qh2mr16997240pbb.81.1421773815621;
 Tue, 20 Jan 2015 09:10:15 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ku12sm3763860pab.39.2015.01.20.09.10.13
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 20 Jan 2015 09:10:15 -0800 (PST)
Date: Tue, 20 Jan 2015 09:10:07 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150120091007.03159d8a@urahara>
In-Reply-To: <1542807.nc7D9yZXnR@xps13>
References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com>
 <2601191342CEEE43887BDE71AB977258213DDF46@irsmsx105.ger.corp.intel.com>
 <54BE4C70.7050406@6wind.com> <1542807.nc7D9yZXnR@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum
 forwarding engine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 17:10:18 -0000

On Tue, 20 Jan 2015 16:18:01 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-01-20 13:39, Olivier MATZ:
> > On 01/20/2015 02:12 AM, Ananyev, Konstantin wrote:
> > >> So I will fix that in my coming patch series. Just for information,
> > >> I'm pretty sure that having PKT_TX_IPV4 and PKT_TX_IP_CSUM as not
> > >> exclusive flag would not require any change anywhere in the PMDs (even
> > >> in i40e).
> > >
> > > Right now - no.
> > > Though as I said from PMD perspective having them exclusive is a bit preferable.
> > > Again, I don't see any big difference from upper layer code.
> > 
> > Sure, it does not make a big difference in terms of code. But
> > in terms of API, the naming of the flag is coherent to what it is
> > used for. And it's easier to find a simple definition, like:
> > 
> >   * Packet is IPv4. This flag must be set when using any offload feature
> >   * (TSO, L3 or L4 checksum) to tell the NIC that the packet is an IPv4
> >   * packet.
> 
> +1
> It's clearer to set PKT_TX_IPV4 in all offload cases of IPv4 packets,
> and add PKT_TX_IP_CSUM when checksum offload is required.
> 
> Simply simpler ;)
> 

Sure. Although in my experience IP checksum is just as cheap done in
software since the header fits in cache.