From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan@kernelim.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id DA8FD255
 for <dev@dpdk.org>; Wed, 28 Jan 2015 23:04:46 +0100 (CET)
Received: by mail-wi0-f174.google.com with SMTP id n3so16077813wiv.1
 for <dev@dpdk.org>; Wed, 28 Jan 2015 14:04:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-type:content-disposition:in-reply-to
 :user-agent;
 bh=btmO9ZJKwy/YRQzShCzz2w3P0OxrK586+fYvICcDouk=;
 b=T5vmMvu4XOOGMwKmFd1ZkHnCWC5a3/VKLEUJ6M2EbIoKfk277Q8RaFPp+buP2pyUXk
 sFgiA2oVE1yyps0xaQHpJvGX18mDCvNBLO2/j3sfswpolTu1bMLQxo2gUnrjBiLMpdW4
 0eqPJ/GZ963/1zfDy9HLqQI1gOV5Imwre80LdR2JInb4A9baTUFbL/sVPvCqXhl7v1bp
 XLaU7yFMZw+aVYKEnZxBi7ZO0PYHTfH5S2DSH1rLspVSbDXdtzJqGS7QR4YgsGHi/X7O
 z1wutRneRb5T7kUYWR7AICIeI2x8P5c3VVX84cMUUGXCRgBGAs2HGNKwEaR5YjjQ7YD+
 EiwQ==
X-Gm-Message-State: ALoCoQkD/cFwUmiLpz6XTLe4loMcYDXa+bIi+NJjQIGfP6k8WfOIIhY608nUNM+z9bfZlwxKHcHh
X-Received: by 10.180.74.229 with SMTP id x5mr11444452wiv.1.1422482686570;
 Wed, 28 Jan 2015 14:04:46 -0800 (PST)
Received: from gmail.com ([188.120.132.209])
 by mx.google.com with ESMTPSA id hr1sm4556387wib.1.2015.01.28.14.04.45
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 28 Jan 2015 14:04:45 -0800 (PST)
Date: Thu, 29 Jan 2015 00:04:43 +0200
From: Dan Aloni <dan@kernelim.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <20150128220443.GA2426@gmail.com>
References: <1421915771-10376-1-git-send-email-dan@kernelim.com>
 <C6ECDF3AB251BE4894318F4E4512369780C3ECFA@IRSMSX109.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780C3ECFA@IRSMSX109.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/linux: allow to map BARs with MSI-X
 tables, around them
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2015 22:04:47 -0000

On Wed, Jan 28, 2015 at 03:01:38PM +0000, Burakov, Anatoly wrote:
> Hi Dan
> 
> Apologies for not looking at it earlier.

No problem, we are all quite busy :)

> > +			if (map_addr != MAP_FAILED
> > +			    &&  memreg[1].offset  &&  memreg[1].size) {
> > +				uint8_t *second_addr =
> > +					((uint8_t *)bar_addr +
> > memreg[1].offset);
> 
> Nitpicking, but probably better to use void* and RTE_PTR_ADD here.

Nitpicking very justified. New patch coming your way.

-- 
Dan Aloni