From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 97CF058CB
 for <dev@dpdk.org>; Thu, 29 Jan 2015 21:39:46 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YGvsH-0006Vn-De; Thu, 29 Jan 2015 15:39:42 -0500
Date: Thu, 29 Jan 2015 15:39:36 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Message-ID: <20150129203936.GH1999@hmsreliant.think-freely.org>
References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com>
 <9416100.1lhCgRCuAQ@xps13>
 <91383E96CE459D47BCE92EFBF5CE73B004F43DE1@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F43DE1@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jan 2015 20:39:46 -0000

On Thu, Jan 29, 2015 at 05:35:09PM +0000, Gonzalez Monroy, Sergio wrote:
> Hi Thomas,
> 
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, January 20, 2015 8:01 AM
> > To: Pattan, Reshma
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library
> > 
> > Hi,
> > 
> > 2015-01-07 16:39, Reshma Pattan:
> > >             1)New library to provide reordering of out of ordered
> > >             mbufs based on sequence number of mbuf. Library uses reorder
> > buffer structure
> > >             which in tern uses two circular buffers called ready and order buffers.
> > >             *rte_reorder_create API creates instance of reorder buffer.
> > >             *rte_reorder_init API initializes given reorder buffer instance.
> > >             *rte_reorder_reset API resets given reorder buffer instance.
> > >             *rte_reorder_insert API inserts the mbuf into order circular buffer.
> > >             *rte_reorder_fill_overflow moves mbufs from order buffer to ready
> > buffer
> > >             to accomodate early packets in order buffer.
> > >             *rte_reorder_drain API provides draining facility to fetch out
> > >             reordered mbufs from order and ready buffers.
> > >
> > >         Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > >         Signed-off-by: Richardson Bruce <bruce.richardson@intel.com>
> > 
> > I think 2 things are missing in this patchset:
> > 
> > 1) Could you show some performance numbers to compare a simple
> > forwarding with and without this library, in the commit log?
> > 
> I'm not allowed to provide specific performance numbers.
Can you elaborate on this?  Why can you not provide specific performance numbers
from your testing?  Is there some concern over the validity of the measurements?