From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id B76252E81
 for <dev@dpdk.org>; Fri, 30 Jan 2015 04:39:37 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 29 Jan 2015 19:36:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,490,1418112000"; d="scan'208";a="644856482"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.254.76.163])
 by orsmga001.jf.intel.com with SMTP; 29 Jan 2015 19:39:35 -0800
Received: by  (sSMTP sendmail emulation); Thu, 29 Jan 2015 20:39:34 -0600
Date: Thu, 29 Jan 2015 20:39:34 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Liang, Cunming" <cunming.liang@intel.com>
Message-ID: <20150130033930.GB2240@bricha3-MOBL3>
References: <1421637666-16872-1-git-send-email-helin.zhang@intel.com>
 <1422501365-12643-1-git-send-email-helin.zhang@intel.com>
 <1422501365-12643-5-git-send-email-helin.zhang@intel.com>
 <20150129233027.GB11276@bricha3-MOBL3>
 <D0158A423229094DA7ABF71CF2FA0DA3118C16B6@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <D0158A423229094DA7ABF71CF2FA0DA3118C16B6@shsmsx102.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 04/17] ixgbe: support of unified packet type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jan 2015 03:39:38 -0000

On Thu, Jan 29, 2015 at 11:52:03PM +0000, Liang, Cunming wrote:
> 
> 
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Thursday, January 29, 2015 4:30 PM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org; Cao, Waterman; Liang, Cunming; Liu, Jijiang; Ananyev,
> > Konstantin
> > Subject: Re: [PATCH 04/17] ixgbe: support of unified packet type
> > 
> > On Thu, Jan 29, 2015 at 11:15:52AM +0800, Helin Zhang wrote:
> > > To unify packet types among all PMDs, bit masks of packet type for
> > > ol_flags are replaced by unified packet type for Vector PMD.
> > >
> > 
> > Two suggestions on the commit log:
> > 1. Can you add scalar and vector into the titles to make it clear how this
> > patch and the previous ones differ
> > 2. Can you add a note calling out performance impacts for this patch. If no
> > performance impacts, then please note that for reviewers.
> [Liang, Cunming] Accept, will update it in v2.
> For performance, lose 1 cycle per packet during 4x10GE io fwd loopback unit test.
> 
Good to know, thanks.

/Bruce