From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BE26C58F4 for ; Mon, 9 Feb 2015 11:27:33 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 09 Feb 2015 02:27:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,543,1418112000"; d="scan'208";a="649409784" Received: from nncongwa-mobl2.ger.corp.intel.com ([10.252.6.84]) by orsmga001.jf.intel.com with SMTP; 09 Feb 2015 02:27:26 -0800 Received: by (sSMTP sendmail emulation); Mon, 09 Feb 2015 10:27:25 +0025 Date: Mon, 9 Feb 2015 10:27:24 +0000 From: Bruce Richardson To: Helin Zhang Message-ID: <20150209102724.GA10516@bricha3-MOBL3> References: <1422501365-12643-1-git-send-email-helin.zhang@intel.com> <1423464049-13457-1-git-send-email-helin.zhang@intel.com> <1423464049-13457-2-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423464049-13457-2-git-send-email-helin.zhang@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 01/15] mbuf: add definitions of unified packet types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2015 10:27:34 -0000 On Mon, Feb 09, 2015 at 02:40:35PM +0800, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet types, > which is not enough to describe all the possible packet types hardware > can recognize. For example, i40e hardware can recognize more than 150 > packet types. Unified packet type is composed of tunnel type, L3 type, > L4 type and inner L3 type fields, and can be stored in mbuf field of > 'packet_type' which is modified from 16 bits to 32 bits in mbuf structure. > Accordingly, the structure of 'rte_kni_mbuf' needs to be modifed as well. > > Signed-off-by: Helin Zhang > Signed-off-by: Cunming Liang > Signed-off-by: Jijiang Liu > --- > .../linuxapp/eal/include/exec-env/rte_kni_common.h | 4 +- > lib/librte_mbuf/rte_mbuf.h | 113 +++++++++++++++++++-- > 2 files changed, 108 insertions(+), 9 deletions(-) > > v2 changes: > * Enlarged the packet_type field from 16 bits to 32 bits. > * Redefined the packet type sub-fields. > * Updated the 'struct rte_kni_mbuf' for KNI according to the mbuf changes. > Since these changes to the mbuf will break the operation of the vector driver, that vector driver needs to be taken into account here. Some suggestions/options: 1. Temporarily disable the VPMD at compile time or at run time as part of this patch, and put the vector changes as the next patch (re-enabling the driver too) 2. Put in the minimum changes for the new mbuf layout into this patch. It will make this patch a little longer, but may still be doable as it's only a couple of fields changing, not the whole structure. /Bruce