From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id 04809903 for ; Wed, 11 Feb 2015 00:49:52 +0100 (CET) Received: by mail-pa0-f45.google.com with SMTP id et14so271158pad.4 for ; Tue, 10 Feb 2015 15:49:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=rNu9ugE8hLhLbnkGRgkrV8rq6bIl0hrFA74Ljas4jYM=; b=U74PzwJpcG3U7mDH9C9Nr4zKi3DzqqF6ijvEkHJy6CLhImYnkq0R6J0Yni0prlmogz DKP6S/C5TA2a2Af7hjbmqPASwA92Q6WDAsgcvzzVFzvpcLghFRfDoZWLi+RFSGBui65w KdsIKxf2eKv0Er/+zQOv95Q9vlpsFIW/95IQ7rUKFNVXahI3Q+7mADeZ9sL6tbyusItG sAl4JrIW87EbftSVOVzBHl9gZWxg2PsC4e6lEtVXZ4ym2Q1DapnPJgyJ0IW6Onca0Zpp Hx5ybFtLFxg6nXmb/MLYCOfuwwxxY38qPLKq1lq2DSnJazAbAzj/BEaLEDhXG3LDtObm C9ZQ== X-Gm-Message-State: ALoCoQlGsAJiPqDLjxM4px9ix9E8pI58G5Q35ILOu0zqroDTIKXtnjmkE9FgMumEnpPqqSB0WnNs X-Received: by 10.66.161.233 with SMTP id xv9mr41536149pab.24.1423612191233; Tue, 10 Feb 2015 15:49:51 -0800 (PST) Received: from uryu.home.lan ([144.49.132.22]) by mx.google.com with ESMTPSA id gi6sm20382752pbd.93.2015.02.10.15.49.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Feb 2015 15:49:50 -0800 (PST) Date: Tue, 10 Feb 2015 15:49:47 -0800 From: Stephen Hemminger To: David Marchand Message-ID: <20150210154947.34d0e292@uryu.home.lan> In-Reply-To: References: <1423247795-22399-1-git-send-email-stephen@networkplumber.org> <1423247795-22399-2-git-send-email-stephen@networkplumber.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/4] pci: allow access to PCI config space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 23:49:52 -0000 On Mon, 9 Feb 2015 10:45:01 +0100 David Marchand wrote: > Hello Stephen,=C2=A0 >=20 > - It looks a bit odd to me, we end up with something asymetric between ui= o / vfio wrt pci config space. > Can we an api consistent between the two ? > Does this mean that your pmd cannot work / has not been used with vfio ? >=20 > - Anyway, I suppose we could reuse this api to remove the RTE_PCI_CONFIG = #ifdef / hardcoded stuff from linux eal / igb_uio. > Opinion ? >=20 >=20 > --=C2=A0 > David Marchand Ok, please send patches to VFIO to use this API. It is not possible to do VFIO style config access through older UIO. Therefore a wrapper like this is needed.