From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 478A13208
 for <dev@dpdk.org>; Wed, 11 Feb 2015 03:18:26 +0100 (CET)
Received: by mail-pa0-f48.google.com with SMTP id eu11so966131pac.7
 for <dev@dpdk.org>; Tue, 10 Feb 2015 18:18:25 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=LXd1H6dNyhGpIkMnydaexj49f6dRD1tGxzA6TNUsmeE=;
 b=HTX5qVbXW2FuGhlnI60TXspZYmbn6TvHBA8+mQliyJkIeGQVvEXM2fX9A74UUOR7rg
 Mzf33tBvrwD0w/jiTI/lyObdBQsgkmacSwtVvlEiLDyjClD9dC9Tlo8J7i03apFCBRE+
 J5nKjX73SYICsOx82W5Ri2Ugv9cE/es5f9B21SJk7f3PDPnZmNFpC5kR4tJ2vm6o58Yr
 MXPq72/dRnRQr21xeHj5HZsnXWROENJFRX0qtwelJ06OfavSHqM+SiidqMiRO4X/vDNa
 kfKArlZ9YXqCsab1unFYnmyDdURFcIOfjWfx+66dbNvw+lp1FoR52coHtN3NQ+hDNFAf
 0cAA==
X-Gm-Message-State: ALoCoQmTNW75ZFnJOMwyRYY3v3SETO2NaUcWhFk6myUiwNYK6775zahBA5jipGxriOCFq6DhU2VK
X-Received: by 10.70.52.234 with SMTP id w10mr42196369pdo.50.1423621105526;
 Tue, 10 Feb 2015 18:18:25 -0800 (PST)
Received: from uryu.home.lan ([144.49.132.22])
 by mx.google.com with ESMTPSA id v5sm4828713pdh.9.2015.02.10.18.18.24
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 10 Feb 2015 18:18:25 -0800 (PST)
Date: Tue, 10 Feb 2015 18:18:22 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Message-ID: <20150210181822.11456a73@uryu.home.lan>
In-Reply-To: <D0FFDD6B.34A9C%yongwang@vmware.com>
References: <1418793196-17953-1-git-send-email-stephen@networkplumber.org>
 <1418793196-17953-6-git-send-email-stephen@networkplumber.org>
 <D0FFDD6B.34A9C%yongwang@vmware.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 02:18:26 -0000

On Wed, 11 Feb 2015 00:54:57 +0000
Yong Wang <yongwang@vmware.com> wrote:

> Why not
> #define VMXNET_ASSERT(x) do { (void)(0); } while (0)
> 
> or simply
> #define VMXNET_ASSERT(x)

Because that will generate unused warnings in Gcc,
and by having the compiler evaluate the result it also makes
sure that junk doesn't get put in.