From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id F1288B4BA for ; Fri, 13 Feb 2015 14:52:01 +0100 (CET) Received: from [67.210.173.2] (helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YMGf0-0002J3-Ls; Fri, 13 Feb 2015 08:52:00 -0500 Date: Fri, 13 Feb 2015 08:51:52 -0500 From: Neil Horman To: Cunming Liang Message-ID: <20150213135152.GB13495@neilslaptop.think-freely.org> References: <1423728996-3004-1-git-send-email-cunming.liang@intel.com> <1423791501-1555-1-git-send-email-cunming.liang@intel.com> <1423791501-1555-6-git-send-email-cunming.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423791501-1555-6-git-send-email-cunming.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 05/19] eal: add support parsing socket_id from cpuset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 13:52:02 -0000 On Fri, Feb 13, 2015 at 09:38:07AM +0800, Cunming Liang wrote: > It returns the socket_id if all cpus in the cpuset belongs > to the same NUMA node, otherwise it will return SOCKET_ID_ANY. > > Signed-off-by: Cunming Liang > --- > v5 changes: > expose cpu_socket_id as eal_cpu_socket_id for linuxapp > eal_cpuset_socket_id() remove static inline and move to c file > > lib/librte_eal/bsdapp/eal/eal_lcore.c | 7 +++++++ > lib/librte_eal/common/eal_thread.h | 11 +++++++++++ > lib/librte_eal/linuxapp/eal/eal_lcore.c | 7 ++++--- > 3 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_lcore.c b/lib/librte_eal/bsdapp/eal/eal_lcore.c > index 72f8ac2..162fb4f 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_lcore.c > +++ b/lib/librte_eal/bsdapp/eal/eal_lcore.c > @@ -41,6 +41,7 @@ > #include > > #include "eal_private.h" > +#include "eal_thread.h" > > /* No topology information available on FreeBSD including NUMA info */ > #define cpu_core_id(X) 0 > @@ -112,3 +113,9 @@ rte_eal_cpu_init(void) > > return 0; > } > + > +unsigned > +eal_cpu_socket_id(__rte_unused unsigned cpu_id) > +{ > + return cpu_socket_id(cpu_id); > +} > diff --git a/lib/librte_eal/common/eal_thread.h b/lib/librte_eal/common/eal_thread.h > index b53b84d..f1ce0bd 100644 > --- a/lib/librte_eal/common/eal_thread.h > +++ b/lib/librte_eal/common/eal_thread.h > @@ -50,4 +50,15 @@ __attribute__((noreturn)) void *eal_thread_loop(void *arg); > */ > void eal_thread_init_master(unsigned lcore_id); > > +/** > + * Get the NUMA socket id from cpu id. > + * This function is private to EAL. > + * > + * @param cpu_id > + * The logical process id. > + * @return > + * socket_id or SOCKET_ID_ANY > + */ > +unsigned eal_cpu_socket_id(unsigned cpu_id); > + > #endif /* EAL_THREAD_H */ > diff --git a/lib/librte_eal/linuxapp/eal/eal_lcore.c b/lib/librte_eal/linuxapp/eal/eal_lcore.c > index 29615f8..ef8c433 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_lcore.c > +++ b/lib/librte_eal/linuxapp/eal/eal_lcore.c > @@ -45,6 +45,7 @@ > > #include "eal_private.h" > #include "eal_filesystem.h" > +#include "eal_thread.h" > > #define SYS_CPU_DIR "/sys/devices/system/cpu/cpu%u" > #define CORE_ID_FILE "topology/core_id" > @@ -71,8 +72,8 @@ cpu_detected(unsigned lcore_id) > * Note: physical package id != NUMA node, but we use it as a > * fallback for kernels which don't create a nodeY link > */ > -static unsigned > -cpu_socket_id(unsigned lcore_id) > +unsigned > +eal_cpu_socket_id(unsigned lcore_id) If you want to export this symbol, then you need to add it to the version map. Neil