From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com
 [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 17170ADB9
 for <dev@dpdk.org>; Mon, 23 Feb 2015 17:59:18 +0100 (CET)
Received: by iecrp18 with SMTP id rp18so24849908iec.9
 for <dev@dpdk.org>; Mon, 23 Feb 2015 08:59:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=GpefIBMKGnChRoLtUQyo6yEVroDCi2yw9cFd7xbFmYA=;
 b=AwxlWwB3zX4rDKwEidV0tKo/jhkjz+Fv3/lNrXn6fyxHnJy/GI5PEPDN/QELtGt++I
 oO4iiH5Ak4losMrdx8Xkxuv3IkZPmbqxH4cJzFOLugSOnaPyrLjjHWbzOuqsGot2rjl6
 XYZvD46PSzhkqg/3R+wEBprTEMsUVTlyCVlcIPwRJJCshEtRyaavvOSzg7Fyd4vRiPMx
 qfKhIEyd8HkKOpyekIvWW24DijXwubxCaKO7Q38HJNnJu6yO7TSDGJxGGNCaHSGm/VVB
 Fy1ciM1NQGeju3B3v/vUcmAkgIN2HE3IcRnGn4yc4fMBAanXZzQnBUvOpAvEG1hcZCmj
 Qy/A==
X-Gm-Message-State: ALoCoQldoBSip2u2Nmqf9CCHaiIffIwpEzMzyPpkXfDQ2LWbmqLiAAeFvTe9UfVvZghs9weIk9Nx
X-Received: by 10.50.56.82 with SMTP id y18mr14318162igp.25.1424710757521;
 Mon, 23 Feb 2015 08:59:17 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id i93sm22384822iod.7.2015.02.23.08.59.16
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 08:59:17 -0800 (PST)
Date: Mon, 23 Feb 2015 08:59:18 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Zhou Danny <danny.zhou@intel.com>
Message-ID: <20150223085918.0b9853a9@urahara>
In-Reply-To: <1424710542-14637-2-git-send-email-danny.zhou@intel.com>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>
 <1424710542-14637-2-git-send-email-danny.zhou@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add rx interrupt
 enable/disable functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 16:59:18 -0000

On Tue, 24 Feb 2015 00:55:37 +0800
Zhou Danny <danny.zhou@intel.com> wrote:

> +int
> +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id,
> +				uint16_t queue_id)
> +{
> +	struct rte_eth_dev *dev;
> +
> +	if (port_id >= nb_ports) {
> +		PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> +		return (-ENODEV);

Please don't use the BSD style of extra useless paren's around
returns.