From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6C5C25A36 for ; Tue, 24 Feb 2015 10:12:40 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 24 Feb 2015 01:12:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,637,1418112000"; d="scan'208";a="670686199" Received: from unknown ([10.243.20.32]) by fmsmga001.fm.intel.com with SMTP; 24 Feb 2015 01:12:36 -0800 Received: by (sSMTP sendmail emulation); Tue, 24 Feb 2015 09:12:35 +0025 Date: Tue, 24 Feb 2015 09:12:35 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20150224091234.GA8416@bricha3-MOBL3> References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <2302266.QHkfKt2YM8@xps13> <54EBE934.8080707@sts.kz> <2004494.FgxmON1ogB@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2004494.FgxmON1ogB@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 09:12:40 -0000 On Tue, Feb 24, 2015 at 04:10:34AM +0100, Thomas Monjalon wrote: > 2015-02-24 09:00, Yerden Zhumabekov: > > > > 23.02.2015 23:36, Thomas Monjalon пишет: > > > 2015-02-19 15:21, Bruce Richardson: > > >> Confirmed, this worked for me too. > > >> Looking at the patches, they look good. However, one thing I think we are missing > > >> is a unit test to verify that all our CRC implementations give the same result. > > >> That would be useful as a sanity check of the software fallback especially. The > > >> existing hash tests, test the hash table implementation rather than the > > >> mathematical argorithm used to compute the hash values. > > >> > > >> Overall, though, software fallback for CRC is something well worthwhile having. > > >> > > >> Series Acked-by: Bruce Richardson > > > Applied, thanks > > > > > > Note: running doxygen compilation helped me to find and fix a small > > > mismatch (parameter alg was flag in comment). > > > > Thanks, Bruce, Thomas. > > > > As for yielding the same hash value, I made a test which runs every > > CRC32 implementation across a number of randomly generated data sets. > > Results are equal on my trial run. > > > > I can post a patch for test_hash.c a bit later if this kind of check > > suffices. > > Yes, seems interesting. Thanks > +1