Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 23 Feb 2015 23:51:31 +0000
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-02-05 07:43, Neil Horman:
> > On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote:
> > > +
> > > +/**
> > > + * Hierarchical scheduler subport statistics reset
> > > + *
> > > + * @param port
> > > + *   Handle to port scheduler instance
> > > + * @param subport_id
> > > + *   Subport ID
> > > + * @return
> > > + *   0 upon success, error code otherwise
> > > + */
> > > +int
> > > +rte_sched_subport_stats_reset(struct rte_sched_port *port,
> > > +			      uint32_t subport_id);
> > > +
> > >  /**
> > >   * Hierarchical scheduler queue statistics read
> > >   *
> > > @@ -338,6 +353,20 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,
> > >  	struct rte_sched_queue_stats *stats,
> > >  	uint16_t *qlen);
> > >  
> > > +/**
> > > + * Hierarchical scheduler queue statistics reset
> > > + *
> > > + * @param port
> > > + *   Handle to port scheduler instance
> > > + * @param queue_id
> > > + *   Queue ID within port scheduler
> > > + * @return
> > > + *   0 upon success, error code otherwise
> > > + */
> > > +int
> > > +rte_sched_queue_stats_reset(struct rte_sched_port *port,
> > > +			    uint32_t queue_id);
> > > +
> > Both need to be added to the version map to expose them properly.
> > Neil
> 
> Stephen, this patchset is partially acked and could enter in 2.0.0-rc1.
> May you send a v3 addressing comments? Or should I break the serie by
> applying only some of them? Or postpone the serie to 2.1?

I can resend v3. Wasn't clear that a conclusion was reached.
IMHO read should not clear.