From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 38C18231C for ; Fri, 27 Feb 2015 19:39:03 +0100 (CET) Received: by wevk48 with SMTP id k48so22065651wev.3 for ; Fri, 27 Feb 2015 10:39:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-type :content-disposition:content-transfer-encoding:in-reply-to; bh=xsOW5hct76FwN8q7I2ay6Tqdiaht7mvwngplfJoKGug=; b=jb1hOk9UHbhUlHmtJDqWx6lYhSPz1nwEVezpS4nOHmN0+XAzaxyDC5gAfeTQ2EgjUk 7HnivVzWe55hmQrOZCsozgBALbIgyCntkGVAcSGcShGV3HDGdPBJ2yfVjt4YS/e7ZE0U HNvYJQcwwruohOfiNvXOZDQ6Va8glntY2lrTe5zf+pnASY1BlCpY4fDv5/Dr2vw1qJWU AKRq9ZcxAz2bdsDLJ5XHqxYBd31SzvZpgYLMq8ZAe8cO2h+iy5Ffu1XlWpVgKE53Cy// TKoZTt3z1WgoywtQUSILLfX8+Kfcj0R9huLATAPel+XT9vijCujXCnjSgIDKRHBa1kpe V48w== X-Gm-Message-State: ALoCoQlVZZSqjRgH/oeTSzvl0oqARdfvo9WoliEnzoQoXy33kwtuLl5FFwVCozurrrhvmqDE+Z0j X-Received: by 10.194.202.162 with SMTP id kj2mr20500004wjc.19.1425062343061; Fri, 27 Feb 2015 10:39:03 -0800 (PST) Received: from 6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id vq9sm7113631wjc.6.2015.02.27.10.39.01 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 27 Feb 2015 10:39:02 -0800 (PST) Date: Fri, 27 Feb 2015 19:38:59 +0100 From: Adrien Mazarguil To: Gleb Natapov Message-ID: <20150227183859.GD23569@6wind.com> Mail-Followup-To: Gleb Natapov , Thomas Monjalon , dev@dpdk.org References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com> <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com> <20150226115137.GU3806@cloudius-systems.com> <7873324.ABPKluIWcB@xps13> <20150226134907.GV3806@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150226134907.GV3806@cloudius-systems.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/3] Mellanox ConnectX-3 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 18:39:03 -0000 On Thu, Feb 26, 2015 at 03:49:07PM +0200, Gleb Natapov wrote: > On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > > 2015-02-26 13:51, Gleb Natapov: > > > Did git pull today. After enabling mlnx pmd compilation fails with: > > > > > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function ‘mlx4_pci_devinit’: > > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments to function ‘rte_eth_dev_allocate’ > > > eth_dev = rte_eth_dev_allocate(name); > > > > Yes, thanks for reporting. > > I didn't test the disabled mlx4 after hotplug integration: > > dpdk.org/browse/dpdk/commit/?id=9f1653e7b7e1746e7c > > > > Clearly, I have to improve my sanity checks. > > Sorry for the inconvenience. > No problem, I fixed that locally, but now I see another issue. I have > several PMDs statically compiled in with my application and I expect > dpdk to choose correct one depending on available HW, but mlnx pmd does > not behave nicely, if its initialization fails it kills entire > application: > > EAL: PCI device 0000:03:00.0 on NUMA socket 0 > EAL: probe driver: 15b3:1003 librte_pmd_mlx4 > EAL: Error - exiting with code: 1 > Cause: Requested device 0000:03:00.0 cannot be used Forgot to set in-reply-to, but I just sent a patch to work around that issue and make mlx4 nicer: http://dpdk.org/dev/patchwork/patch/3796/ -- Adrien Mazarguil 6WIND