From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 4A38F903 for ; Sat, 28 Feb 2015 23:38:31 +0100 (CET) Received: by iecvy18 with SMTP id vy18so39388027iec.6 for ; Sat, 28 Feb 2015 14:38:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Guv0XVGi2rJwizYOjEUZBid5TV011nCitzl2yBshDy0=; b=ETx+P6YALmJhXN5Yqzuvfv/lwwDHrof3slqVbTZY68L8kRsUp1/HnzDRGxr2G8Rr81 +3gfHlmB7Ey1Wzo5sqdViUI3HsyIphl/CNr7j35654y2bWemH7y1/E++5IJU9KoSo1az UsP3pNBXFak0IoGBS/RzR7odT6c6jtZCQcN3eRyvdACRcHj7RhWdigd6+Ka4HSzB0KOJ HYzP1nuXy0Ruv0J+w3uU+jqEIdGvfCdut1a0bZu0SziSM4Ix1T3BhrHiSjoyYwHDM0tU oXJAls0NBq/IEJHWy0CVPBmNsSyVrs2aNzMwPQPIYz7uEY+2rK8hfZJI3H50ORybpTf3 LuTw== X-Gm-Message-State: ALoCoQlEfk8AN9fBLPY+x71QlB4SKEbCxUOCy5OGIxp1E3iZuEhmPTU6x3NDfBcVg5cWNkkkEqZ7 X-Received: by 10.43.48.129 with SMTP id uw1mr22705448icb.85.1425163110656; Sat, 28 Feb 2015 14:38:30 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id x10sm4077866igl.13.2015.02.28.14.38.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Feb 2015 14:38:30 -0800 (PST) Date: Sat, 28 Feb 2015 14:38:32 -0800 From: Stephen Hemminger To: David Marchand Message-ID: <20150228143832.1f4a08cf@urahara> In-Reply-To: References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com> <1425012976-10173-1-git-send-email-cunming.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 0/8] Interrupt mode PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2015 22:38:31 -0000 On Fri, 27 Feb 2015 11:38:25 +0100 David Marchand wrote: > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang = wrote: > v6 changes > =C2=A0- split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. > =C2=A0- rewrite rte_intr_rx_wait/rte_intr_rx_set. > =C2=A0- using vector number instead of queue_id as interrupt API params. > =C2=A0- patch reorder and split. >=20 >=20 > Ok, so after looking at this patchset, I would say this is the right dire= ction, but still this is too limited. > The ethdev part and the vfio eventfds part look acceptable to me. > But thinking about it, I could just reuse a standard event library with t= he eventfds I would get from ethdev without a need for a new eal api. Also, you need to introduce a flag (in pci drv_flags?) so that application = can know if poll mode interrupt will work or not on the given device before configuring it.