From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com
 [209.85.223.171]) by dpdk.org (Postfix) with ESMTP id 1B6963B5
 for <dev@dpdk.org>; Sat, 28 Feb 2015 23:57:11 +0100 (CET)
Received: by iecrl12 with SMTP id rl12so39459013iec.2
 for <dev@dpdk.org>; Sat, 28 Feb 2015 14:57:10 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=KtO6RmHQnrsulWN++rb7Z+Tvo2lKtZyg1Ox/qS73ZYI=;
 b=RoUhNeILvbItWfvMLHhB/73e4i5W58YC7ntGFROPKOMND4JFxc/SL2lJHTpDai6XLJ
 G+kpcsvtCy8Mma6+bE8wXP/WlPvOcn+z7Q9KQeQP3tgRrKIdCU5CQ8HHxULXYXv3p3Px
 dh9Pzjm+nAyRT8diHEdN4V0sf6bP/ZkEuzV92YYeg6+iNuVwSJTCZ7L5G6RFs/sbGRwc
 qzaaF/2TXQMxyxAmmJt8IVnojVgiv5zJcgJmErglUi/k/DeLB7KtZeFK9foOJQ3yKf4k
 L2qe8SL1izH5LJ7ToCbU2FAMmBf06psbTxDKRrcgevcT4sMvbi/3YImJ9/maXRElUPLP
 ww/Q==
X-Gm-Message-State: ALoCoQlp7ezya8/TKS09PlMHTEcQ4X0ZYAKWZhIsJCgKvriS2dXAX3rB+w9N5j3kVjYc8UbLXQ+2
X-Received: by 10.107.136.80 with SMTP id k77mr12173580iod.53.1425164230461;
 Sat, 28 Feb 2015 14:57:10 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id w9sm4119175igl.0.2015.02.28.14.57.09
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sat, 28 Feb 2015 14:57:10 -0800 (PST)
Date: Sat, 28 Feb 2015 14:57:12 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Cunming Liang <cunming.liang@intel.com>
Message-ID: <20150228145712.3ae5c432@urahara>
In-Reply-To: <1425012976-10173-9-git-send-email-cunming.liang@intel.com>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>
 <1425012976-10173-1-git-send-email-cunming.liang@intel.com>
 <1425012976-10173-9-git-send-email-cunming.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 8/8] l3fwd-power: enable one-shot rx
 interrupt and polling/interrupt mode switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2015 22:57:11 -0000

On Fri, 27 Feb 2015 12:56:16 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +	/* Enable one-shot rx interrupt */
> +	rte_spinlock_lock(&(locks[port_id]));
> +	rte_eth_dev_rx_intr_enable(port_id, queue_id);
> +	rte_spinlock_unlock(&(locks[port_id]));
> +

If always requires locks like this, then the API should
do the locking internally.