From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com
 [209.85.223.174]) by dpdk.org (Postfix) with ESMTP id 2EF053B5
 for <dev@dpdk.org>; Sun,  1 Mar 2015 00:00:11 +0100 (CET)
Received: by iecrd18 with SMTP id rd18so39414113iec.8
 for <dev@dpdk.org>; Sat, 28 Feb 2015 15:00:10 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=eG3UXeUjpCZHseyGJx3ENXYqzD9wVbCsc346oFhKoPk=;
 b=ape531aqmmf4ZipbloNOufT4tsLbe2jaaeSIOv++BDL3+eq1ym28br5qJIoWTq0SlA
 pvgPxD37kn3icLxRZ0VAkUojA3i1/+m8H65VRT17tk3v/NI6PlJ1tDEAuaW/ex5nZHtO
 4bBruf00oX2jE6KYMD+mhh1dc7zyWKo8H09m8uN8sVEfBTSSUKVe8WyKwewekb9hxlF2
 ACQ5r3O3qW+qfMAJVRnMF1kYw3y/yGgTcj45Mqy7c/Z3knVZrAKVof0Mv2x5hxsVo21g
 nPH1FvCkBtEY/ICrNWHWp7zJv7gB/uVRA8Pu63D3E41FL/qMSuzyNVBtOhMaYIJOwpwq
 zVIA==
X-Gm-Message-State: ALoCoQlD8oYgU2hETsJ/DzM0fOS8Z3A73/mqCjzyY9adZ/ebALCA0cIU2MsmJU8iD4zg/A/nfoFR
X-Received: by 10.50.62.110 with SMTP id x14mr12166815igr.2.1425164410708;
 Sat, 28 Feb 2015 15:00:10 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id i16sm5134104ioe.17.2015.02.28.15.00.10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sat, 28 Feb 2015 15:00:10 -0800 (PST)
Date: Sat, 28 Feb 2015 15:00:12 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Cunming Liang <cunming.liang@intel.com>
Message-ID: <20150228150012.1a1b4fbe@urahara>
In-Reply-To: <1425012976-10173-9-git-send-email-cunming.liang@intel.com>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>
 <1425012976-10173-1-git-send-email-cunming.liang@intel.com>
 <1425012976-10173-9-git-send-email-cunming.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 8/8] l3fwd-power: enable one-shot rx
 interrupt and polling/interrupt mode switch
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2015 23:00:11 -0000

On Fri, 27 Feb 2015 12:56:16 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +/* ethernet addresses of ports */
> +static rte_spinlock_t locks[RTE_MAX_ETHPORTS];

Comment is incorrect this is a lock array not an address array.


>  static struct rte_eth_conf port_conf = {
>  	.rxmode = {
> -		.mq_mode	= ETH_MQ_RX_RSS,
> +		.mq_mode = ETH_MQ_RX_RSS,

Please don't mix white space changes with code changes