From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 1EAD7959
 for <dev@dpdk.org>; Sun,  1 Mar 2015 14:48:26 +0100 (CET)
Received: from [2001:470:8:a08:215:ff:fecc:4872] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1YS4EF-000596-JT; Sun, 01 Mar 2015 08:48:24 -0500
Date: Sun, 1 Mar 2015 08:48:18 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Raz Amir <razamir22@gmail.com>
Message-ID: <20150301134818.GA31578@neilslaptop.think-freely.org>
References: <1424932400-66862-1-git-send-email-razamir22@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424932400-66862-1-git-send-email-razamir22@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices,
 and re-probe during driver unload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Mar 2015 13:48:26 -0000

On Thu, Feb 26, 2015 at 06:33:20AM +0000, Raz Amir wrote:
> Added code that saves the pointers to the detached devices, during
> driver loading, and during driver unloading, go over the list,
> and re-attach them by calling device_probe_and_attach
> on each device.
> 
> Signed-off-by: Raz Amir <razamir22@gmail.com>
> ---
>  lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> index 5ae8560..7d702a5 100644
> --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$");
>  
>  #define MAX_BARS (PCIR_MAX_BAR_0 + 1)
>  
> +#define MAX_DETACHED_DEVICES	128
> +static device_t detached_devices[MAX_DETACHED_DEVICES] = {};
> +static int last_detached = 0;
>  
>  struct nic_uio_softc {
>  	device_t        dev_t;
> @@ -291,14 +294,35 @@ nic_uio_load(void)
>  		if (dev != NULL)
>  			for (i = 0; i < NUM_DEVICES; i++)
>  				if (pci_get_vendor(dev) == devices[i].vend &&
> -						pci_get_device(dev) == devices[i].dev)
> +						pci_get_device(dev) == devices[i].dev) {
> +							if (last_detached+1 < MAX_DETACHED_DEVICES) {
> +								printf("nic_uio_load: detaching and storing dev=%p\n", dev);
No printfs.  Use the logging facilities

> +								detached_devices[last_detached++] = dev;
> +							}
> +							else {
> +								printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. dev=%p won't be reattached\n",
> +									MAX_DETACHED_DEVICES, dev);
Dittto

> +							}
> +								
>  							device_detach(dev);
> +				}
>  	}
>  }
>  
>  static void
>  nic_uio_unload(void)
>  {
> +	int i;
> +	printf("nic_uio_unload: entered ... \n");
> +
> +	for (i = 0; i < last_detached; i++) {
> +		printf("nic_uio_unload: calling to device_probe_and_attach for dev=%p...\n",
> +			detached_devices[i]);
> +		device_probe_and_attach(detached_devices[i]);
Where is this defined?  It doesn't appear to be in the latest dpdk.

> +		printf("nic_uio_unload: done.\n");
> +	}
> +
> +	printf("nic_uio_unload: leaving ... \n");
>  }
>  
>  static int
> -- 
> 2.1.2
> 
>