From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 2BDD95677 for ; Fri, 6 Mar 2015 17:24:40 +0100 (CET) Received: by padet14 with SMTP id et14so28736364pad.11 for ; Fri, 06 Mar 2015 08:24:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=hZrEkQ9CWhpuPYcjNlyb/cvbT/h13DayUiDQn4gpauQ=; b=KLfWnRvfwQ7mKVvRelx1Myx6A4MYNDMEzCPE9xCOe+DQoOwQG1+7hbSgwWdCFYjnZA cSV2/19++CwWhOpja1hvrb2jJ/MtT0reDY8ldqapsRElrkhKdHXD3NJoInERarBu8I6D Afy+0t77UcV3MhA6QC6ghXJop5nRFj6wp9lurKzDoO6L++FPpOHqWJP5epc8XFqbiqb7 xS6sEW/XhV9ICw6EnuUL42t7zywAxJLlAqvNbMLCYvG3LeGqNEG+JMvOTHfnNMRHcsgz LJWrSJJw8H6eO1SvHbTVzzdwHW1WFif1G6ELhn+ktmbpZ/qJzUJPyrGiVQetfOy6X7jd L/cQ== X-Gm-Message-State: ALoCoQlxSyGrYV02kGO2Eb378rIVEg5dhTkhze6ahVDAqfIR2j2Rwh9acApKUxzMvSPZYatRoUxs X-Received: by 10.70.54.198 with SMTP id l6mr27343460pdp.74.1425659079399; Fri, 06 Mar 2015 08:24:39 -0800 (PST) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id mi4sm9949762pdb.44.2015.03.06.08.24.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Mar 2015 08:24:39 -0800 (PST) Date: Fri, 6 Mar 2015 08:24:36 -0800 From: Stephen Hemminger To: "Ouyang, Changchun" Message-ID: <20150306082436.43415409@urahara> In-Reply-To: References: <1425602726-26538-1-git-send-email-stephen@networkplumber.org> <1425602726-26538-3-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 16:24:40 -0000 On Fri, 6 Mar 2015 03:39:47 +0000 "Ouyang, Changchun" wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Friday, March 6, 2015 8:45 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering > > > > Vlan filtering is an option, and not a requirement. > > If host does not support filtering then it can be done in software. > > > > The question is that guest only send command, no real action to do the vlan filter. > So if both host and guest have no real action for vlan filter, who will do it? > > Thanks > Changchun > > The virtio driver has features. Guest can not send commands to host where feature bit not enabled. Application can call filter_set and check if filter worked or not. Our code already had to do MAC and VLAN validation of incoming packets therefore if hardware can't do vlan match, there is no problem. I would expect other applications would do the same thing. Failing during configuration is bad. DPDK API should never force application to play "guess the working configuration" with the device driver or do string match on "which device is this anyway"