From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 7BEB4568F
 for <dev@dpdk.org>; Fri,  6 Mar 2015 17:55:18 +0100 (CET)
Received: by padfb1 with SMTP id fb1so43679223pad.7
 for <dev@dpdk.org>; Fri, 06 Mar 2015 08:55:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=uRHGnJXG64uC08TvZRjdGzJpDLyk8DsxeKpBvgsz8eY=;
 b=Qutg+HD+2oXKDeIMyJ8ZFxQMUfrTeeOo6OA3Y8BG7wGkghF0qMZU3W+0NlgKzLvxe+
 dRKuL9kfcz8MXQMaMr6eOAbdcVwcShU6tlLiuPc/4PGgAQt7Li4vKdXGuVUGPHb+ny8A
 iST0CLXOpZtlc8B5xLYH/WRfgCRK65p4m8Plkxn2xSXh2RiYmu5DF2LV6O+9/Km14SHv
 6IbuK1mu3NbMo/M2pgqZG/lgOax64Ub3OmtnMRRQv/oW7XBqCFHh+cxLaQ+CrGJtZjQ8
 YwyvVGSEmHheniryMCSBcfhKH3JYfkWCtLI9DwD4r+uPEnhXdNS1sXY0j9QMSm+yCvGj
 6Z7A==
X-Gm-Message-State: ALoCoQkeRUsJoYRaydfMo5+Nb1Noa3zVyJ6+ier/CiN+XO6zpo/cyxdi1cbfYwG8cKzGLTpAnSIn
X-Received: by 10.66.184.106 with SMTP id et10mr27866972pac.138.1425660917702; 
 Fri, 06 Mar 2015 08:55:17 -0800 (PST)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id fl4sm10096098pab.8.2015.03.06.08.55.17
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 06 Mar 2015 08:55:17 -0800 (PST)
Date: Fri, 6 Mar 2015 08:55:14 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20150306085514.1b0ecbd2@urahara>
In-Reply-To: <CALwxeUuVtO3Dp4Y3UWQU9HtaVtAffOTzV9jnuETMvZ+NSgamfA@mail.gmail.com>
References: <1425602726-26538-1-git-send-email-stephen@networkplumber.org>
 <1425602726-26538-2-git-send-email-stephen@networkplumber.org>
 <F52918179C57134FAEC9EA62FA2F962511A0C1AF@shsmsx102.ccr.corp.intel.com>
 <20150306082057.5c505f54@urahara>
 <CALwxeUuVtO3Dp4Y3UWQU9HtaVtAffOTzV9jnuETMvZ+NSgamfA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] virtio: initialize iopl when device is
 initialized
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Mar 2015 16:55:18 -0000

On Fri, 6 Mar 2015 17:33:58 +0100
David Marchand <david.marchand@6wind.com> wrote:

> Is eth_virtio_dev_init() not a better place rather than eal ?
> 
> I prefer avoiding #ifdef pmd in eal.

No virtio_dev_init is called too late, after interrupt handling
threads are spawned.

/* Launch threads, called at application init(). */
int
rte_eal_init(int argc, char **argv)
{
	int i, fctret, ret;
...
	if (rte_eal_intr_init() < 0)
		rte_panic("Cannot init interrupt-handling thread\n");
...
	
	if (rte_eal_dev_init() < 0)
		rte_panic("Cannot init pmd devices\n"