From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 68B1B5A9C
 for <dev@dpdk.org>; Mon,  9 Mar 2015 11:27:46 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 09 Mar 2015 03:27:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,366,1422950400"; d="scan'208";a="537997861"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.26])
 by orsmga003.jf.intel.com with SMTP; 09 Mar 2015 03:27:16 -0700
Received: by  (sSMTP sendmail emulation); Mon, 09 Mar 2015 10:27:43 +0025
Date: Mon, 9 Mar 2015 10:27:42 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Raz Amir <razamir22@gmail.com>
Message-ID: <20150309102742.GA960@bricha3-MOBL3>
References: <1424932400-66862-1-git-send-email-razamir22@gmail.com>
 <1425467754-2693-1-git-send-email-razamir22@gmail.com>
 <84B1AA3E-21E4-4A41-ADEE-B37E27147243@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84B1AA3E-21E4-4A41-ADEE-B37E27147243@gmail.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] pci: save list of detached devices,
 and re-probe during driver unload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2015 10:27:46 -0000

On Mon, Mar 09, 2015 at 10:07:29AM +0200, Raz Amir wrote:
> Hi, gentle reminder about this patch...
> 
> On Mar 4, 2015, at 1:15 PM, Raz Amir <razamir22@gmail.com> wrote:
> 
> Added code that saves the pointers to the detached devices, during
> driver loading, and during driver unloading, go over the list,
> and re-attach them by calling device_probe_and_attach
> on each device.
> 
> Signed-off-by: Raz Amir <razamir22@gmail.com>
> ---
> lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 32 ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> index 5ae8560..78e4dea 100644
> --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
> @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$");
> 
> #define MAX_BARS (PCIR_MAX_BAR_0 + 1)
> 
> +#define MAX_DETACHED_DEVICES    128
> +static device_t detached_devices[MAX_DETACHED_DEVICES] = {};
> +static int num_detached = 0;
> 
> struct nic_uio_softc {
>    device_t        dev_t;
> @@ -289,16 +292,37 @@ nic_uio_load(void)
> 
>        dev = pci_find_bsf(bus, device, function);
>        if (dev != NULL)
> -            for (i = 0; i < NUM_DEVICES; i++)
> -                if (pci_get_vendor(dev) == devices[i].vend &&
> -                        pci_get_device(dev) == devices[i].dev)
> -                            device_detach(dev);
> +            continue;
Since we have changed the body to be a continue statement, I think the condition
above needs to be flipped.

/Bruce