From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com
 [209.85.213.182]) by dpdk.org (Postfix) with ESMTP id E6EDA568F
 for <dev@dpdk.org>; Fri, 20 Mar 2015 21:51:11 +0100 (CET)
Received: by ignm3 with SMTP id m3so3002279ign.0
 for <dev@dpdk.org>; Fri, 20 Mar 2015 13:51:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=9tu86WqDfruEVwKTrh4AJOuUdD6lcVzP2zu67x46fjk=;
 b=ZnShN/JZlQuL6jftnlUFs67vgTmTn8QJHHiEQz6g/Jb8wK9erJ1HPGhz3cIVzILwsQ
 c41eTsvo8O+DZQ/Q/5R2C4j+mpVkQthggyU4ErLfMyqnAQao4neosHT2CvhsOIsXylL7
 dR//Y+nnDvGKKmEweC31ikGGP/1OyiPGyZm1zBcwCfRsYRs+rbHZLMmLkWsNffw6KxGI
 BnRPWKkKa0jZNvT8aOaitF8MAImIR6Hh7xVJ56FZDpexJVb8zuanh0mCmGG7qYtLgVjE
 xCJhNC/YzL2y6f3iEAfV2NFTu3XBPcreoabJKqz7o9ulTF+jmk3HgckxN6slxpObiJ4j
 ET+w==
X-Gm-Message-State: ALoCoQnmP+OQsySq1+B1Br92AlD0ISm3d91hdH1XRzMZs7wvPnbYb7OIQdgUT0i1rEyD1S65dfix
X-Received: by 10.107.132.39 with SMTP id g39mr126988440iod.62.1426884671324; 
 Fri, 20 Mar 2015 13:51:11 -0700 (PDT)
Received: from uryu.home.lan ([172.56.12.202])
 by mx.google.com with ESMTPSA id y142sm3885714iod.25.2015.03.20.13.51.10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 20 Mar 2015 13:51:11 -0700 (PDT)
Date: Fri, 20 Mar 2015 15:51:08 -0500
From: Stephen Hemminger <stephen@networkplumber.org>
To: Cunming Liang <cunming.liang@intel.com>
Message-ID: <20150320155108.55f836bf@uryu.home.lan>
In-Reply-To: <1425012976-10173-8-git-send-email-cunming.liang@intel.com>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>
 <1425012976-10173-1-git-send-email-cunming.liang@intel.com>
 <1425012976-10173-8-git-send-email-cunming.liang@intel.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 7/8] igb: enable rx queue interrupts for PF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2015 20:51:12 -0000

On Fri, 27 Feb 2015 12:56:15 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

>  
>  /*
> + * It clears the interrupt causes and enables the interrupt.
> + * It will be called once only during nic initialized.
> + *
> + * @param dev
> + *  Pointer to struct rte_eth_dev.
> + *
> + * @return
> + *  - On success, zero.
> + *  - On failure, a negative value.
> + */
> +static int eth_igb_rxq_interrupt_setup(struct rte_eth_dev *dev)
> +{
> +

This function should be void
It always succeeds and the caller just not check the return value.

If you did this in one driver, I bet other drivers have same problem.