* [dpdk-dev] Rx/Tx callbacks in debug mode
@ 2015-03-23 14:31 Thomas Monjalon
2015-03-23 15:01 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2015-03-23 14:31 UTC (permalink / raw)
To: Bruce Richardson, John Mcnamara; +Cc: dev
Hi,
As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a
debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG.
I'm afraid these implementations have been forgotten when adding
optional Rx/Tx callbacks. Or is it intended?
What do you think of removing these debug functions and insert extra
checks with ifdef in an unique function?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] Rx/Tx callbacks in debug mode
2015-03-23 14:31 [dpdk-dev] Rx/Tx callbacks in debug mode Thomas Monjalon
@ 2015-03-23 15:01 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2015-03-23 15:01 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Mon, Mar 23, 2015 at 03:31:48PM +0100, Thomas Monjalon wrote:
> Hi,
>
> As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a
> debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG.
> I'm afraid these implementations have been forgotten when adding
> optional Rx/Tx callbacks. Or is it intended?
>
> What do you think of removing these debug functions and insert extra
> checks with ifdef in an unique function?
The omission was unintentional. I think removing duplicate functions and using a
common version, if possible, is always a good idea, or else things like this
keep happening! :-)
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 14:31 [dpdk-dev] Rx/Tx callbacks in debug mode Thomas Monjalon
2015-03-23 15:01 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).