From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com
 [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id DCE755A8C
 for <dev@dpdk.org>; Mon, 30 Mar 2015 22:35:03 +0200 (CEST)
Received: by pddn5 with SMTP id n5so70477879pdd.2
 for <dev@dpdk.org>; Mon, 30 Mar 2015 13:35:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
 :content-type:content-transfer-encoding;
 bh=jJkqCCYzf17R4mYc7TiY3s/+pAiDZtGRxKvRmAQHQeE=;
 b=D696lhqq/2nKijtnKlyn25OKSwuN0PNPzxLhiJ2SbiRwxrzRUuvnQVsUmKYwM3cZF0
 Xl9Y2JrAoyyWYe9+3CMl2aEbMe7Y2U0GSutbhWgMXdnxMJubHVcnmmejCP5ooYzdtoeL
 Elr5lXFNvzIo2fiN8VRjCFe2UAFCsf3jISCu+vcQQCaZoigOaHlQ8KiBVGEzk1LBeCar
 bXk6t4WMJ43bEnHh244Lg5N7WZIYO3B/e0I9It0SEE720Vgyq1sJ43iAXPVooO0ezmjI
 JViZoL+WBb2PGzLzCy+HKps16LhSTOB/IPk9wJ7InohhqXrG2eDRdq18X2hhdXNBl2e5
 2sew==
X-Gm-Message-State: ALoCoQlNvsrYVoH6F0JK9DaxxF9OAD+9iDWyj2OmTP1EZn5Bl6+GETqguRuCQtqtxGYFdEi/0XP/
X-Received: by 10.66.124.164 with SMTP id mj4mr62597696pab.83.1427747703248;
 Mon, 30 Mar 2015 13:35:03 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ob7sm11592199pdb.13.2015.03.30.13.35.02
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 30 Mar 2015 13:35:02 -0700 (PDT)
Date: Mon, 30 Mar 2015 13:35:07 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Message-ID: <20150330133507.77ff6b1d@urahara>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: [dpdk-dev] VFIO in setup.sh
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2015 20:35:04 -0000

This code around vfio in setup script looks incorrect, is anyone using it:

1. Why set the execute bit, when you want read-write?
   Looks like a bug (or worse a security hole).
	# make sure regular users can read /dev/vfio
	echo "chmod /dev/vfio"
	sudo chmod a+x /dev/vfio

3. Why depend on location of vfio module in kernel tree?
   modprobe does the right thing and finds it.

	VFIO_PATH="kernel/drivers/vfio/pci/vfio-pci.ko"

	echo "Loading VFIO module"
	/sbin/lsmod | grep -s vfio_pci > /dev/null
	if [ $? -ne 0 ] ; then
		if [ -f /lib/modules/$(uname -r)/$VFIO_PATH ] ; then
			sudo /sbin/modprobe vfio-pci
		fi
	fi