From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] VFIO in setup.sh
Date: Mon, 30 Mar 2015 13:37:42 -0700 [thread overview]
Message-ID: <20150330133742.57adef52@urahara> (raw)
In-Reply-To: <20150330133507.77ff6b1d@urahara>
On Mon, 30 Mar 2015 13:35:07 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> This code around vfio in setup script looks incorrect, is anyone using it:
>
> 1. Why set the execute bit, when you want read-write?
> Looks like a bug (or worse a security hole).
> # make sure regular users can read /dev/vfio
> echo "chmod /dev/vfio"
> sudo chmod a+x /dev/vfio
>
> 3. Why depend on location of vfio module in kernel tree?
> modprobe does the right thing and finds it.
>
> VFIO_PATH="kernel/drivers/vfio/pci/vfio-pci.ko"
>
> echo "Loading VFIO module"
> /sbin/lsmod | grep -s vfio_pci > /dev/null
> if [ $? -ne 0 ] ; then
> if [ -f /lib/modules/$(uname -r)/$VFIO_PATH ] ; then
> sudo /sbin/modprobe vfio-pci
> fi
> fi
>
>
Never mind, it is fine. /dev/vfio is a directory and loading
the module creates the directory.
next prev parent reply other threads:[~2015-03-30 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 20:35 Stephen Hemminger
2015-03-30 20:37 ` Stephen Hemminger [this message]
2015-03-31 9:05 ` Burakov, Anatoly
2015-03-31 9:26 ` Andre Richter
2015-03-31 9:35 ` Burakov, Anatoly
2015-03-31 12:41 ` Andre Richter
2015-03-31 12:59 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330133742.57adef52@urahara \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).