DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Zhou, Danny" <danny.zhou@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] UIO pci-generic support broke igb_uio
Date: Wed, 15 Apr 2015 08:57:31 -0700	[thread overview]
Message-ID: <20150415085731.054f701f@urahara> (raw)
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AB5C943@SHSMSX104.ccr.corp.intel.com>

On Wed, 15 Apr 2015 07:19:39 +0000
"Zhou, Danny" <danny.zhou@intel.com> wrote:

> Could you please send out the steps for us to reproduce it? I guess you have applied
> v6 interrupt patches to perform interrupt related tests, right?
> 
> We cannot reproduce it now.
> 
> The support to in_kernel uio_pci_generic avoids using igb_uio this DPDK specific kernel module, 
> so it will be much easier for any Linux distribution to package DPDK.


Very simple. Run with link state enabled and igb_uio driver.

Looking more closely, I think the right way to fix this is to fix the
upstream uio_pci_generic to support controlling interrupts properly, rather
than trying to do it directly in userspace.

The problem is that doing it userspace is inherently racy because
the userspace config access does not do proper locking.

It really is an upstream kernel bug. Will send patch upstream to do it
the right way. But that won't help distributions.

  reply	other threads:[~2015-04-15 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15  1:06 Stephen Hemminger
2015-04-15  7:19 ` Zhou, Danny
2015-04-15 15:57   ` Stephen Hemminger [this message]
2015-04-15 16:34   ` [dpdk-dev] [PATCH 0/2] fix UIO support broken by 2.0 Stephen Hemminger
2015-04-15 16:36     ` [dpdk-dev] [PATCH 1/2 kernel] uio: add irq control support to uio_pci_generic Stephen Hemminger
2015-04-15 16:38     ` [dpdk-dev] [PATCH 2/2 dpdk] uio: fix pci generic driver breakage Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150415085731.054f701f@urahara \
    --to=stephen@networkplumber.org \
    --cc=danny.zhou@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).