From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 34E9BC360 for ; Wed, 15 Apr 2015 11:52:19 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 15 Apr 2015 02:52:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,581,1422950400"; d="scan'208";a="695562415" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.33]) by fmsmga001.fm.intel.com with SMTP; 15 Apr 2015 02:52:16 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 Apr 2015 10:52:15 +0025 Date: Wed, 15 Apr 2015 10:52:15 +0100 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150415095215.GB7948@bricha3-MOBL3> References: <1428614982-14135-1-git-send-email-stephen@networkplumber.org> <1428614982-14135-2-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428614982-14135-2-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] rte_ethdev: remove extra inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 09:52:19 -0000 On Thu, Apr 09, 2015 at 02:29:39PM -0700, Stephen Hemminger wrote: > There is no reason to inline functions that are not in the critical > path. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_ether/rte_ethdev.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index e20cca5..3120c3a 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -179,7 +179,7 @@ enum { > DEV_ATTACHED > }; > > -static inline void > +static void > rte_eth_dev_data_alloc(void) > { > const unsigned flags = 0; > @@ -255,7 +255,7 @@ rte_eth_dev_allocate(const char *name, enum rte_eth_dev_type type) > return eth_dev; > } > > -static inline int > +static int > rte_eth_dev_create_unique_device_name(char *name, size_t size, > struct rte_pci_device *pci_dev) > { > @@ -2415,7 +2415,7 @@ rte_eth_dev_priority_flow_ctrl_set(uint8_t port_id, struct rte_eth_pfc_conf *pfc > return (-ENOTSUP); > } > > -static inline int > +static int > rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf, > uint16_t reta_size) > { > @@ -2439,7 +2439,7 @@ rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf, > return -EINVAL; > } > > -static inline int > +static int > rte_eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf, > uint16_t reta_size, > uint8_t max_rxq) > @@ -2648,7 +2648,7 @@ rte_eth_led_off(uint8_t port_id) > * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find > * an empty spot. > */ > -static inline int > +static int > get_mac_addr_index(uint8_t port_id, struct ether_addr *addr) > { > struct rte_eth_dev_info dev_info; > @@ -2789,7 +2789,7 @@ rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf, > * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find > * an empty spot. > */ > -static inline int > +static int > get_hash_mac_addr_index(uint8_t port_id, struct ether_addr *addr) > { > struct rte_eth_dev_info dev_info; > -- > 2.1.4 >