From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E937B5A40 for ; Wed, 15 Apr 2015 11:54:49 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 15 Apr 2015 02:54:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,581,1422950400"; d="scan'208";a="695562974" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.33]) by fmsmga001.fm.intel.com with SMTP; 15 Apr 2015 02:54:47 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 Apr 2015 10:54:46 +0025 Date: Wed, 15 Apr 2015 10:54:46 +0100 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150415095446.GD7948@bricha3-MOBL3> References: <1428614982-14135-1-git-send-email-stephen@networkplumber.org> <1428614982-14135-4-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428614982-14135-4-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/4] rte_ethdev: make tables const X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 09:54:50 -0000 On Thu, Apr 09, 2015 at 02:29:41PM -0700, Stephen Hemminger wrote: > The statistics tables and null mac address should be immutable. > Fix up get_addr routines to accept const args. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_ether/rte_ethdev.c | 44 +++++++++++++++++++++---------------------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 56e22ea..416e778 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -119,34 +119,34 @@ struct rte_eth_xstats_name_off { > unsigned offset; > }; > > -static struct rte_eth_xstats_name_off rte_stats_strings[] = { > - {"rx_packets", offsetof(struct rte_eth_stats, ipackets)}, > - {"tx_packets", offsetof(struct rte_eth_stats, opackets)}, > - {"rx_bytes", offsetof(struct rte_eth_stats, ibytes)}, > - {"tx_bytes", offsetof(struct rte_eth_stats, obytes)}, > - {"tx_errors", offsetof(struct rte_eth_stats, oerrors)}, > - {"rx_missed_errors", offsetof(struct rte_eth_stats, imissed)}, > - {"rx_crc_errors", offsetof(struct rte_eth_stats, ibadcrc)}, > - {"rx_bad_length_errors", offsetof(struct rte_eth_stats, ibadlen)}, > - {"rx_errors", offsetof(struct rte_eth_stats, ierrors)}, > - {"alloc_rx_buff_failed", offsetof(struct rte_eth_stats, rx_nombuf)}, > - {"fdir_match", offsetof(struct rte_eth_stats, fdirmatch)}, > - {"fdir_miss", offsetof(struct rte_eth_stats, fdirmiss)}, > - {"tx_flow_control_xon", offsetof(struct rte_eth_stats, tx_pause_xon)}, > - {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)}, > - {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)}, > - {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)}, > +static const struct rte_eth_xstats_name_off rte_stats_strings[] = { > + {"rx_packets", offsetof(struct rte_eth_stats, ipackets)}, > + {"tx_packets", offsetof(struct rte_eth_stats, opackets)}, > + {"rx_bytes", offsetof(struct rte_eth_stats, ibytes)}, > + {"tx_bytes", offsetof(struct rte_eth_stats, obytes)}, > + {"tx_errors", offsetof(struct rte_eth_stats, oerrors)}, > + {"rx_missed_errors", offsetof(struct rte_eth_stats, imissed)}, > + {"rx_crc_errors", offsetof(struct rte_eth_stats, ibadcrc)}, > + {"rx_bad_length_errors", offsetof(struct rte_eth_stats, ibadlen)}, > + {"rx_errors", offsetof(struct rte_eth_stats, ierrors)}, > + {"alloc_rx_buff_failed", offsetof(struct rte_eth_stats, rx_nombuf)}, > + {"fdir_match", offsetof(struct rte_eth_stats, fdirmatch)}, > + {"fdir_miss", offsetof(struct rte_eth_stats, fdirmiss)}, > + {"tx_flow_control_xon", offsetof(struct rte_eth_stats, tx_pause_xon)}, > + {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)}, > + {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)}, > + {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)}, > }; > #define RTE_NB_STATS (sizeof(rte_stats_strings) / sizeof(rte_stats_strings[0])) > > -static struct rte_eth_xstats_name_off rte_rxq_stats_strings[] = { > +static const struct rte_eth_xstats_name_off rte_rxq_stats_strings[] = { > {"rx_packets", offsetof(struct rte_eth_stats, q_ipackets)}, > {"rx_bytes", offsetof(struct rte_eth_stats, q_ibytes)}, > }; > #define RTE_NB_RXQ_STATS (sizeof(rte_rxq_stats_strings) / \ > sizeof(rte_rxq_stats_strings[0])) > > -static struct rte_eth_xstats_name_off rte_txq_stats_strings[] = { > +static const struct rte_eth_xstats_name_off rte_txq_stats_strings[] = { > {"tx_packets", offsetof(struct rte_eth_stats, q_opackets)}, > {"tx_bytes", offsetof(struct rte_eth_stats, q_obytes)}, > {"tx_errors", offsetof(struct rte_eth_stats, q_errors)}, > @@ -2651,7 +2651,7 @@ rte_eth_led_off(uint8_t port_id) > * an empty spot. > */ > static int > -get_mac_addr_index(uint8_t port_id, struct ether_addr *addr) > +get_mac_addr_index(uint8_t port_id, const struct ether_addr *addr) > { > struct rte_eth_dev_info dev_info; > struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > @@ -2666,7 +2666,7 @@ get_mac_addr_index(uint8_t port_id, struct ether_addr *addr) > return -1; > } > > -static struct ether_addr null_mac_addr = {{0, 0, 0, 0, 0, 0}}; > +static const struct ether_addr null_mac_addr; > > int > rte_eth_dev_mac_addr_add(uint8_t port_id, struct ether_addr *addr, > @@ -2792,7 +2792,7 @@ rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf, > * an empty spot. > */ > static int > -get_hash_mac_addr_index(uint8_t port_id, struct ether_addr *addr) > +get_hash_mac_addr_index(uint8_t port_id, const struct ether_addr *addr) > { > struct rte_eth_dev_info dev_info; > struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > -- > 2.1.4 >