From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 49FD3C314
 for <dev@dpdk.org>; Mon, 18 May 2015 16:00:14 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 18 May 2015 07:00:09 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,453,1427785200"; d="scan'208";a="495066069"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.63])
 by FMSMGA003.fm.intel.com with SMTP; 18 May 2015 07:00:07 -0700
Received: by  (sSMTP sendmail emulation); Mon, 18 May 2015 15:00:04 +0025
Date: Mon, 18 May 2015 15:00:04 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Message-ID: <20150518140004.GC12176@bricha3-MOBL3>
References: <1431937081-20083-1-git-send-email-olivier.matz@6wind.com>
 <1431937081-20083-2-git-send-email-olivier.matz@6wind.com>
 <20150518135305.GA12176@bricha3-MOBL3> <5559EFAC.9010604@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5559EFAC.9010604@6wind.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] examples/bond: fix compilation with clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 14:00:15 -0000

On Mon, May 18, 2015 at 03:57:00PM +0200, Olivier MATZ wrote:
> Hi Bruce,
> 
> On 05/18/2015 03:53 PM, Bruce Richardson wrote:
> > On Mon, May 18, 2015 at 10:17:58AM +0200, Olivier Matz wrote:
> >> Fix the following compilation error:
> >>
> >> examples/bond/main.c:717:1: error: control reaches end of
> >>   non-void function [-Werror,-Wreturn-type]
> >>
> >> The prompt() function does not return anything, so fix its prototype
> >> to be void.
> >>
> >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > 
> > Out of interest, what version of clang throws up this error?
> 
> $ clang --version
> Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
> Target: x86_64-pc-linux-gnu
> Thread model: posix
> 
> And by the way, the gcc version I used for the other patches of the
> series:
> 
> $ gcc --version
> gcc (Debian 4.9.2-10) 4.9.2
> 
> 
> Regards,
> Olivier
> 

Thanks. I was just curious as I wasn't seeing issues with clang 3.6 on Fedora.

/Bruce

> > 
> > /Bruce
> > 
> >> ---
> >>  examples/bond/main.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/examples/bond/main.c b/examples/bond/main.c
> >> index e90dc1d..4622283 100644
> >> --- a/examples/bond/main.c
> >> +++ b/examples/bond/main.c
> >> @@ -705,7 +705,7 @@ cmdline_parse_ctx_t main_ctx[] = {
> >>  };
> >>  
> >>  /* prompt function, called from main on MASTER lcore */
> >> -static void *prompt(__attribute__((unused)) void *arg1)
> >> +static void prompt(__attribute__((unused)) void *arg1)
> >>  {
> >>  	struct cmdline *cl;
> >>  
> >> -- 
> >> 2.1.4
> >>