From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 3DA32B38D
 for <dev@dpdk.org>; Tue, 19 May 2015 12:24:07 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 19 May 2015 03:24:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,457,1427785200"; d="scan'208";a="697055818"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.63])
 by orsmga001.jf.intel.com with SMTP; 19 May 2015 03:24:05 -0700
Received: by  (sSMTP sendmail emulation); Tue, 19 May 2015 11:24:03 +0025
Date: Tue, 19 May 2015 11:24:03 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20150519102402.GD11036@bricha3-MOBL3>
References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org>
 <1429284934-3261-2-git-send-email-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429284934-3261-2-git-send-email-stephen@networkplumber.org>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 10:24:07 -0000

On Fri, Apr 17, 2015 at 08:35:33AM -0700, Stephen Hemminger wrote:
> Function always returned 0 and no one was checking anyway.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_eal/common/eal_common_log.c  | 3 +--
>  lib/librte_eal/common/include/rte_log.h | 5 +----
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
> index ff44d23..3802f9c 100644
> --- a/lib/librte_eal/common/eal_common_log.c
> +++ b/lib/librte_eal/common/eal_common_log.c
> @@ -158,14 +158,13 @@ rte_log_set_history(int enable)
>  }
>  
>  /* Change the stream that will be used by logging system */
> -int
> +void
>  rte_openlog_stream(FILE *f)
>  {
>  	if (f == NULL)
>  		rte_logs.file = default_log_stream;
>  	else
>  		rte_logs.file = f;
> -	return 0;
>  }
>  
>  /* Set global log level */
> diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
> index f83a0d9..888ee19 100644
> --- a/lib/librte_eal/common/include/rte_log.h
> +++ b/lib/librte_eal/common/include/rte_log.h
> @@ -110,11 +110,8 @@ extern FILE *eal_default_log_stream;
>   *
>   * @param f
>   *   Pointer to the stream.
> - * @return
> - *   - 0 on success.
> - *   - Negative on error.
>   */
> -int rte_openlog_stream(FILE *f);
> +void rte_openlog_stream(FILE *f);
>  
>  /**
>   * Set the global log level.
> -- 
> 2.1.4
>