From: Stephen Hemminger <stephen@networkplumber.org>
To: "Liang, Cunming" <cunming.liang@intel.com>
Cc: dev@dpdk.org, cumming.lian@intel.com
Subject: Re: [dpdk-dev] [PATCH 5/5] uio: integrate MSI-X support
Date: Mon, 25 May 2015 10:42:33 -0700 [thread overview]
Message-ID: <20150525104233.532583c6@urahara> (raw)
In-Reply-To: <5562E37B.7090605@intel.com>
On Mon, 25 May 2015 16:55:23 +0800
"Liang, Cunming" <cunming.liang@intel.com> wrote:
> > + irqs.fd = intr_handle->fd;
> > +
> > + if (ioctl(intr_handle->vfio_dev_fd, UIO_MSI_IRQ_SET, &irqs) < 0) {
> It would be strange if using vfio_dev_fd in 'uio_msix_' related function.
Just minor variable name. The whole set of fd's etc, probably need better names..
next prev parent reply other threads:[~2015-05-25 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:40 [dpdk-dev] [PATCH 0/5] receive IRQ related patches Stephen Hemminger
2015-05-18 17:40 ` [dpdk-dev] [PATCH 1/5] ethdev: check for rxq interrupt support Stephen Hemminger
2015-05-18 17:40 ` [dpdk-dev] [PATCH 2/5] ethdev: remove unnecessary checks Stephen Hemminger
2015-05-18 17:40 ` [dpdk-dev] [PATCH 3/5] ethdev: fix errors if RTE_ETHDEV_DEBUG enabled Stephen Hemminger
2015-05-18 17:40 ` [dpdk-dev] [PATCH 4/5] uio: new driver with MSI-X support Stephen Hemminger
2015-05-25 6:01 ` Liang, Cunming
2015-05-25 17:41 ` Stephen Hemminger
2015-05-18 17:40 ` [dpdk-dev] [PATCH 5/5] uio: integrate " Stephen Hemminger
2015-05-25 8:55 ` Liang, Cunming
2015-05-25 17:42 ` Stephen Hemminger [this message]
2015-07-09 0:28 ` [dpdk-dev] [PATCH 0/5] receive IRQ related patches Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525104233.532583c6@urahara \
--to=stephen@networkplumber.org \
--cc=cumming.lian@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).