From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com
 [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 1336E9A92
 for <dev@dpdk.org>; Tue, 26 May 2015 16:59:54 +0200 (CEST)
Received: by padbw4 with SMTP id bw4so94694697pad.0
 for <dev@dpdk.org>; Tue, 26 May 2015 07:59:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=p17BoqP3/qyqEAC/v3UF8AqZ47dLFxjS/RWWQ+W5gkU=;
 b=DWigB2gGgpP+bEjyuu7yxeogMtzcrbg0QQxU41NLtH8qZ9Ph7oY6+6CWZvg9l+9OEH
 GmMPKv/CL16MfzRthfGSXOTQCMg4cG80wZW5FXa4EcaZl2Nixjlj5BrQojjJzh5mpMl4
 xhvC2ZqXHzBhwR1vLjES9CRWvk7HUL97XNIE1KHhzpnHy3VF79/SZi30lGpIdQ+HDQrd
 KrEkQsQ4Q49vLuH69IcafdhHN0KeDTOrz7DrQWi8xuPn3AihvjtN+pSmyREnbIlKZ88j
 dYRKJQCZdH/NZfs19ra3EfrtBr9d0H6bdr4JIZXPb78qyHNluBu5mDAGJZVNmbLBS1OQ
 Bg5w==
X-Gm-Message-State: ALoCoQmES1HCakNeGOSXOmPsbF09gVvo3+CD7O+7VnC5T04yWcQbLGpVDLSrsa5WBRxVxCYdHFpg
X-Received: by 10.68.68.161 with SMTP id x1mr50020430pbt.49.1432652393449;
 Tue, 26 May 2015 07:59:53 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id fs16sm13378992pdb.12.2015.05.26.07.59.52
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 May 2015 07:59:53 -0700 (PDT)
Date: Tue, 26 May 2015 07:59:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Damjan Marion <damarion@cisco.com>
Message-ID: <20150526075957.431dae36@urahara>
In-Reply-To: <1432549252-8630-1-git-send-email-damarion@cisco.com>
References: <1432549252-8630-1-git-send-email-damarion@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] virtio: fix crash if CQ is not negotiated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2015 14:59:54 -0000

On Mon, 25 May 2015 12:20:52 +0200
Damjan Marion <damarion@cisco.com> wrote:

> Fix NULL dereference if virtio control queue is not negotiated.
> 
> Signed-off-by: Damjan Marion <damarion@cisco.com>

This is good belt and suspenders thing to have, but did you see early
patches to check the feature bits and not call this code?

Acked-by: Stephen Hemminger <stephen@networkplumber.org>