From: Stephen Hemminger <stephen@networkplumber.org>
To: Wei li <liw@dtdream.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: tcp pkt with virtio header in one desc
Date: Thu, 28 May 2015 07:50:30 -0700 [thread overview]
Message-ID: <20150528075030.7ad1a9d4@urahara> (raw)
In-Reply-To: <8975cbf4-0f4d-4da4-8e45-6b75629072e1@liw0310-PC.local>
On Thu, 28 May 2015 16:19:44 +0800
Wei li <liw@dtdream.com> wrote:
> + if (desc->flags & VRING_DESC_F_NEXT)
> + {
> + /* Discard first buffer as it is the virtio header */
> + desc = &vq->desc[desc->next];
> + vb_offset = 0;
> + vb_avail = desc->len;
> + }
> + else /* virtio header in one desc with real pkt */
> + {
> + /* strip the virtio header */
> + vb_offset = vq->vhost_hlen;
> + vb_avail = desc->len - vq->vhost_hlen;
> +
This code looks correct, but please follow the same style as
other code in the driver. The virtio driver uses Linux/BSD
style:
if () {
} else {
}
next prev parent reply other threads:[~2015-05-28 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 8:19 Wei li
2015-05-28 13:32 ` Ouyang, Changchun
2015-05-28 14:50 ` Stephen Hemminger [this message]
2015-05-28 15:22 ` Ouyang, Changchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528075030.7ad1a9d4@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liw@dtdream.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).