From: Stephen Hemminger <stephen@networkplumber.org>
To: Ivan Boule <ivan.boule@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/5] multicast address filtering
Date: Fri, 29 May 2015 08:17:49 -0700 [thread overview]
Message-ID: <20150529081749.130e3636@urahara> (raw)
In-Reply-To: <55683282.8020306@6wind.com>
On Fri, 29 May 2015 11:33:54 +0200
Ivan Boule <ivan.boule@6wind.com> wrote:
> On 05/28/2015 06:21 PM, Stephen Hemminger wrote:
> > On Thu, 28 May 2015 17:05:18 +0200
> > Ivan Boule <ivan.boule@6wind.com> wrote:
> >
> >> Introduce PMD API to set the list of multicast MAC addresses filtered
> >> by a port.
> >> Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf.
> >> Implementation for physical PMDs i40e, i40evf, enic, and fm10k left
> >> to their respective maintainers.
> >>
> >> Ivan Boule (5):
> >> ethdev: add multicast address filtering
> >> app/testpmd: new command to add/remove multicast MAC addresses
> >> e1000: add multicast MAC address filtering
> >> ixgbe: add multicast MAC address filtering
> >> app/testpmd: fix reply to a multicast ICMP request
> >>
> >> app/test-pmd/cmdline.c | 52 ++++++++++++++
> >> app/test-pmd/config.c | 142 ++++++++++++++++++++++++++++++++++++++
> >> app/test-pmd/icmpecho.c | 65 +++++++++++++++--
> >> app/test-pmd/testpmd.h | 6 ++
> >> drivers/net/e1000/em_ethdev.c | 17 +++++
> >> drivers/net/e1000/igb_ethdev.c | 18 +++++
> >> drivers/net/ixgbe/ixgbe_ethdev.c | 32 +++++++++
> >> lib/librte_ether/rte_ethdev.c | 17 +++++
> >> lib/librte_ether/rte_ethdev.h | 26 +++++++
> >> 9 files changed, 369 insertions(+), 6 deletions(-)
> >>
> >
> > Looks good, could you also add support for virtio and vmxnet3?
> >
> As for physical NICs (i40e, etc.) listed above, I let the maintainers of
> the remaining NICs where this function is relevant to implement and to
> test it.
> By the way, I supposed that Guest front-end vNICs were always in
> promiscuous mode by construction.
> Said differently: that all packets supplied "from the outside" to the
> Host vNIC back-end driver were systematically delivered to the Guest
> vNIC front-end, whatever their destination MAC address, VLAN id., etc.
> Did I missed something ?
>
For virtio, there is a mac address table, and Multicast filtering is done
by adding the multicast address to the macs table.
For vmxnet3, ther is multicast address table (shared with host) so that
multicast filtering can be done hypervisor.
next prev parent reply other threads:[~2015-05-29 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 15:05 Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 1/5] ethdev: add " Ivan Boule
2015-05-28 16:22 ` Stephen Hemminger
2015-05-29 7:52 ` Ivan Boule
2015-05-29 8:56 ` [dpdk-dev] [PATCH v2 " Ivan Boule
2015-05-29 13:12 ` [dpdk-dev] default unicast mac address - was: " Thomas Monjalon
2015-05-29 15:18 ` Stephen Hemminger
2015-05-28 15:05 ` [dpdk-dev] [PATCH 2/5] app/testpmd: new command to add/remove multicast MAC addresses Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 3/5] e1000: add multicast MAC address filtering Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 4/5] ixgbe: " Ivan Boule
2015-05-28 15:05 ` [dpdk-dev] [PATCH 5/5] app/testpmd: fix reply to a multicast ICMP request Ivan Boule
2015-05-28 16:21 ` [dpdk-dev] [PATCH 0/5] multicast address filtering Stephen Hemminger
2015-05-29 9:33 ` Ivan Boule
2015-05-29 15:17 ` Stephen Hemminger [this message]
2015-06-12 13:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529081749.130e3636@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ivan.boule@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).