From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
 [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 75FBD58E4
 for <dev@dpdk.org>; Fri, 29 May 2015 17:18:58 +0200 (CEST)
Received: by padbw4 with SMTP id bw4so62786190pad.0
 for <dev@dpdk.org>; Fri, 29 May 2015 08:18:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=I4UDMxoSzvyz0CzzKpWolxrnCZ0KGCsW6YJuKx+tqNc=;
 b=ceQYs0HuAQlWrGb9PPOY4TJY4Z09Ezcu6JUWdnAmTpgTnSlSW2PamleKHA6zjr4ZR0
 9kg3MKXQ8xMk7jaxFd69wSVUPa/izyYrxjDRI5K38IMc2CQuURL7LOaFDbR6SYZMGEA9
 ZTw/zAgXCjXvrj81NKeEvAvY3teUR2QanLHr/TTUYramUFWC/s+VtZCB7Mq9C/h8eJNQ
 oloXTABMUUaDQerJcev6nQVCP+jocRy7ra1/eA+P8RxSg4XtoeFjpMTECqbUYGDW3S7t
 wQtu3EHx7sc+ulRYCFeXEhmIZDD0D14Oqbu3Cnl+nqvh3BE26KaBQJ0YETVuFcpA2EDW
 +DaQ==
X-Gm-Message-State: ALoCoQk9NsU/Om5mPM2sVxi78ax16ENWH5nMMxL4Oa50GgUOueDYPE6l9IMRclFe78hHXic95jT2
X-Received: by 10.70.25.37 with SMTP id z5mr15945712pdf.36.1432912737800;
 Fri, 29 May 2015 08:18:57 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id a10sm5922841pdn.57.2015.05.29.08.18.57
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 May 2015 08:18:57 -0700 (PDT)
Date: Fri, 29 May 2015 08:18:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150529081857.383fe0c3@urahara>
In-Reply-To: <3149965.63Z4QvtXnx@xps13>
References: <1432825523-19006-1-git-send-email-ivan.boule@6wind.com>
 <1432825523-19006-2-git-send-email-ivan.boule@6wind.com>
 <20150528092256.292e566c@urahara> <3149965.63Z4QvtXnx@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] default unicast mac address - was: add multicast
 address filtering
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2015 15:18:59 -0000

On Fri, 29 May 2015 15:12:28 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> Hi Stephen,
> 
> Looking at mac address management, you and Changchun added an entry in
> driver ops to be able to change the default mac address with virtio:
> 	http://dpdk.org/browse/dpdk/commit/?id=5186fb1f37fe986
> Other ops functions (mac_addr_add/remove) manage the secondary unicast
> mac addresses and have a wrapper function in the API:
> 	http://dpdk.org/doc/api/rte__ethdev_8h.html#aa2b81750086f5f9e55cf65e5cf9f2c58
> 
> It seems now that the review of the above patch was too weak and I'd like
> these issues to be fixed:
> 	- mac_addr_set must be wrapped by rte_eth_dev_mac_addr_set()
> 	- eth_mac_addr_set_t must be fixed to explicitly state that it
> replaces the default address

Sure, also some other drivers need mac_addr_set hook.