From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com
 [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 965601396
 for <dev@dpdk.org>; Fri, 29 May 2015 17:22:17 +0200 (CEST)
Received: by pdea3 with SMTP id a3so55798028pde.2
 for <dev@dpdk.org>; Fri, 29 May 2015 08:22:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=eq49O5A9DWIoIOTXrjrWEqJrP3ZS2fZsbjnUhIMvbvI=;
 b=IGx7ohssJoWaaw0EBhF4loV+lPUz3mAENj4QvZmYRCZ0myjCv5qKF/MpXK8Pg1V2lw
 peKzVY2K5IH/YSCV6JR4zCuXu5plBuJ6pDgVyLg78HY3vy7vzbEuVlAYKqv/LgnGH6gq
 7d/ywj+ECM9sz8d7SZz1rYdcOEY3WwwyJyogDTEh77BbOhaBhAPsgsjHLI9Nv7+zB6RA
 BSgh1b2FpNxzgKUNf9xycxOd9VNTJOR0il29sPltjTNCHpD5/V90JTo5rhZDcBJonOPP
 6uQOcJIc3/2+8Wsd2W4UTrUK/zyCm6HeZvnoAIRdIbUhQEnDoB43hVs3RfDfnrqE9/hd
 bBYQ==
X-Gm-Message-State: ALoCoQmlUytDMVPdxsRFtS8hVINaxOP3rrPMYtVBgAK0XB7sNFuaDUVS93fo10KrjaQPy9GFP0Cq
X-Received: by 10.70.101.2 with SMTP id fc2mr15975444pdb.77.1432912936973;
 Fri, 29 May 2015 08:22:16 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id eo3sm5910502pbd.66.2015.05.29.08.22.16
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 May 2015 08:22:16 -0700 (PDT)
Date: Fri, 29 May 2015 08:22:19 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150529082219.57614c70@urahara>
In-Reply-To: <1432905309-912-3-git-send-email-liang-min.wang@intel.com>
References: <1432905309-912-1-git-send-email-liang-min.wang@intel.com>
 <1432905309-912-3-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, aharton@cisco.com, bruce.richardson@intle.com
Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide
 ethtool-alike APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2015 15:22:18 -0000

On Fri, 29 May 2015 09:15:09 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +	drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t);
> +	drvinfo->testinfo_len = 0;


Providing a hook to access more functionality is good and compatiablity
with old API's is helpful.  Too bad ethtool is kind of a clunky old
inflexible, and easily broken with changes. But that is not your fault.

Duplicating eth_stats in ethtool is not helpful.
This is actively discouraged for Linux device drivers.