From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id B265A5A96
 for <dev@dpdk.org>; Fri, 29 May 2015 17:57:15 +0200 (CEST)
Received: by padbw4 with SMTP id bw4so63453845pad.0
 for <dev@dpdk.org>; Fri, 29 May 2015 08:57:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=Vx+AJl8lQYWQQ+ycvmBV9WXQ43WxdeDq/5wKGzI21Hs=;
 b=N7gdvJdOLhTLtaKKPMmVLiDp+701+UFinYDVrjT/9LsWkQ2vqqajUGvAlXCklh7DgZ
 r/xPsPX/sS2yknkvEwr7hQnLbMdBiuu8rA6fcBkZTbFjs3yTe8q9Rpu5aII6RV49WN+w
 2uXdY4R7b+GAov+v0uUQsm/chBvp0byRLUgAwIqf3Gus33miEmyNgWgY1PqJMHAe6gfI
 mp6Wd8iPY31oTdr3dO38iz48RVkRZJdLHPjnvOAFOGhYTl7OvRXJCSCYIdWu9rvVLune
 c4gKt8zUjd89JrN/i/Ap9yAh4s+TeR97yLyuoNzZFQrR4mcMr4LWbrUX7TusRCPzJpGz
 ojkg==
X-Gm-Message-State: ALoCoQm6d8ILeKzreKJdsTm0e/krhnJPcZHQ2iKebQluMyxIErN52CJg+9kutudGC8QIXIwNZ8sg
X-Received: by 10.70.49.168 with SMTP id v8mr16294344pdn.24.1432915035119;
 Fri, 29 May 2015 08:57:15 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id by13sm6010409pdb.37.2015.05.29.08.57.14
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 May 2015 08:57:14 -0700 (PDT)
Date: Fri, 29 May 2015 08:57:17 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Cunming Liang <cunming.liang@intel.com>
Message-ID: <20150529085717.106a770a@urahara>
In-Reply-To: <1432889125-20255-10-git-send-email-cunming.liang@intel.com>
References: <1432198563-16334-1-git-send-email-cunming.liang@intel.com>
 <1432889125-20255-1-git-send-email-cunming.liang@intel.com>
 <1432889125-20255-10-git-send-email-cunming.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v9 09/12] ixgbe: enable rx queue interrupts
 for both PF and VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2015 15:57:16 -0000

On Fri, 29 May 2015 16:45:22 +0800
Cunming Liang <cunming.liang@intel.com> wrote:

> +		if (intr_handle->intr_vec == NULL) {
> +			PMD_INIT_LOG(ERR, "Failed to allocate %d rx_queues"
> +				     "intr_vec\n", dev->data->nb_rx_queues);
> +			return -1;
> +		}
> +

Please return an actual error code (like -ENOMEM) rather than generic -1.
It allows for easier diagnosis when using API's.