From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 87B59BDC2 for ; Tue, 2 Jun 2015 18:21:53 +0200 (CEST) Received: from pps.filterd (m0048193.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.7/8.14.7) with SMTP id t52G46A0006047; Tue, 2 Jun 2015 09:21:50 -0700 Received: from brmwp-exchub01.corp.brocade.com ([208.47.132.227]) by mx0a-000f0801.pphosted.com with ESMTP id 1us2kc9ew2-8 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 02 Jun 2015 09:21:49 -0700 Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by BRMWP-EXCHUB01.corp.brocade.com (172.16.186.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 2 Jun 2015 10:21:16 -0600 Received: from urahara (10.252.8.17) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 2 Jun 2015 10:21:14 -0600 Date: Tue, 2 Jun 2015 09:21:17 -0700 From: Stephen Hemminger To: Cunming Liang Message-ID: <20150602092117.3a0b443a@urahara> In-Reply-To: <1433228006-24661-3-git-send-email-cunming.liang@intel.com> References: <1432889125-20255-1-git-send-email-cunming.liang@intel.com> <1433228006-24661-1-git-send-email-cunming.liang@intel.com> <1433228006-24661-3-git-send-email-cunming.liang@intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-06-02_14:2015-06-02,2015-06-02,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1506020214 X-Mailman-Approved-At: Tue, 02 Jun 2015 18:27:04 +0200 Cc: dev@dpdk.org, liang-min.wang@intel.com Subject: Re: [dpdk-dev] [PATCH v10 02/13] eal/linux: add rte_epoll_wait/ctl support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 16:21:54 -0000 On Tue, 2 Jun 2015 14:53:15 +0800 Cunming Liang wrote: > The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup. > It defines 'struct rte_epoll_event' as the event param. > The 'op' uses the same enum as epoll_wait/ctl does. > The epoll event support to carry a raw user data and to register a callback which is exectuted during wakeup. > > Signed-off-by: Cunming Liang Minor polish comments, not blockers. > +static inline int > +eal_init_tls_epfd(void) > +{ > + int pfd = epoll_create(255); > + if (pfd < 0) { Kernel style checker wants blank line after declaration here. / > +int > +rte_epoll_ctl(int epfd, int op, int fd, > + struct rte_epoll_event *event); > + > +/** > + * The function returns the per thread epoll instance. > + * > + * @return > + * epfd the epoll instance refered to. Spell check: 'refered' may be misspelled - perhaps 'referred'? > + */ > +int > +rte_intr_tls_epfd(void);