From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 52D63C34C for ; Thu, 4 Jun 2015 16:58:11 +0200 (CEST) Received: by qkoo18 with SMTP id o18so25170293qko.1 for ; Thu, 04 Jun 2015 07:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=nf1UWlkTTvn/Y1T8bTovfuCWRHO5qfptF9eYQS9w3yA=; b=PFddTbsisTI3qT1t8SE5Lt1fnAD1hMTAbni8kz+P4BmNo/6/9W8pxbrC2AF12wp2in QKMQEOcyOITUnCHoTMWjYYk38ssynMSU+xQvtFksrum4BuUObIIhc8//7QwC8tlKnlI7 S7dIf5ZU4YS/yu/AXM5GjPkYunDAL2dPG3e/NcIEjEaoI9xVDFR0eLtSzH8acm+kfaPl 2VP9M+Ys0flMOF7X6u34iSitALyZzVO2CFlLUQKc0XgruMRD0iADWTYldugcApIt0esG fKmvDihH6+4qcobCqVm+Lz5Mjz+QIWaw0wPij8U7dRzmghj9/VTZH3fgwh7Q/Wz70sPB Ebdw== X-Gm-Message-State: ALoCoQnq4RHthpoCTqtWJucbdtlMYlLhRw6L/yA+wT23SGhwnQaw0o4qv2kn0iGLmQG0HWv8BIK5 X-Received: by 10.55.42.130 with SMTP id q2mr71676410qkq.20.1433429890895; Thu, 04 Jun 2015 07:58:10 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id g92sm2493488qgf.20.2015.06.04.07.58.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 07:58:10 -0700 (PDT) Date: Thu, 4 Jun 2015 07:58:10 -0700 From: Stephen Hemminger To: "Andrew Harvey (agh)" Message-ID: <20150604075810.0c087b21@urahara> In-Reply-To: References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <38737329.jBeOYmBEyN@xps13> <24712227.WkznNjn3ZB@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Wang, Liang-min" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 14:58:11 -0000 On Wed, 3 Jun 2015 02:09:39 +0000 "Andrew Harvey (agh)" wrote: > I believe that their is value in this interface for software stacks not > based on Linux being moved toward DPDK that need simple operations like > getting the mac address. Some of these stacks have a dearth of resources > available and dedicating a core/thread to KNI to get/set a mac address > is considered excessive. There are also issues with 32/64 bit kernel > integration > using KNI. If the ethtool interface is not the correct interface then > please help me > understand what should/could have been used. If ethtool is considered 'old > and clunky=C2=B9 > Stephen's and your input would be valuable in designing another interface > with > similar properties. The use-case is pretty simple and there is no plans > for moving > anything back into the kernel on the contrary its the complete opposite. >=20 > =E2=80=B9 Andy We have DPDK API's to do this, and any added wrappers make it bigger. I don't see why calling your ethtool API is better than calling rte_eth* API. If there is a missing functionality in the rte_ethXXX api's for an application then add that. For example: rte_eth_mac_addr_get()