From: Bruce Richardson <bruce.richardson@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command
Date: Mon, 8 Jun 2015 11:47:23 +0100 [thread overview]
Message-ID: <20150608104723.GB3996@bricha3-MOBL3> (raw)
In-Reply-To: <55754EAA.8000409@6wind.com>
On Mon, Jun 08, 2015 at 10:13:30AM +0200, Olivier MATZ wrote:
> Hi Bruce,
>
> On 06/05/2015 01:05 PM, Bruce Richardson wrote:
> > On Fedora 22, the "ar" binary operates by default in deterministic mode,
> > making the "u" parameter irrelevant, and leading to warning messages
> > getting printed in the build output like below.
> >
> > INSTALL-LIB librte_kvargs.a
> > ar: `u' modifier ignored since `D' is the default (see `U')
> >
> > There are two options to remove these warnings:
> > * add in the "U" flag to make "ar" non-deterministic again
> > * remove the "u" flag to have all objects always updated
>
> Indeed, I think that removing 'u' won't have any impact in this case,
> as we always regenerate the full archive without updating it.
> However, why not explicitly use 'D' to have the same behavior across
> distributions?
>
> Regards,
> Olivier
>
Good question. I didn't bother adding in the "D" flag as I didn't see the need.
[Basically, I asked "why" instead of "why not" :-)]
However, if folks think it's worthwhile doing, I don't think doing a V2 of
this patch would tax me unduly :-)
/Bruce
>
> >
> > This patch takes the second approach.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > mk/rte.lib.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> > index 0d7482d..6bd67aa 100644
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -70,7 +70,7 @@ else
> > _CPU_LDFLAGS := $(CPU_LDFLAGS)
> > endif
> >
> > -O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
> > +O_TO_A = $(AR) crs $(LIB) $(OBJS-y)
> > O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
> > O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
> > O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
> >
next prev parent reply other threads:[~2015-06-08 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 11:05 Bruce Richardson
2015-06-08 8:13 ` Olivier MATZ
2015-06-08 10:47 ` Bruce Richardson [this message]
2015-06-09 12:51 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2015-06-09 14:17 ` Olivier MATZ
2015-06-29 12:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608104723.GB3996@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).