[dpdk-dev] Headers files with BSD license in kernel

[dpdk-dev] Headers files with BSD license in kernel

[Miguel Bernal Marin]

Hi,

I'm working on Clear Linux project, and when I was integrating DPDK
kernel modules to our kernel I found there are two headers with 
BSD License

rte_pci_dev_feature_defs.h
rte_pci_dev_features.h

those are included in igb_uio module.

Are those licenses correct?

Thanks,
Miguel

Re: [dpdk-dev] Headers files with BSD license in kernel

[Miguel Bernal Marin]

Including maintainers in CC

On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> Hi,
> 
> I'm working on Clear Linux project, and when I was integrating DPDK
> kernel modules to our kernel I found there are two headers with 
> BSD License
> 
> rte_pci_dev_feature_defs.h
> rte_pci_dev_features.h
> 
> those are included in igb_uio module.
> 
> Are those licenses correct?
> 
> Thanks,
> Miguel
> 

Re: [dpdk-dev] Headers files with BSD license in kernel

[Zhang, Helin]

Hi Miguel

My thought is there might be something wrong. Let's see what comments from other experts!
Thank you very much for the good catch!

Regards,
Helin

> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin@linux.intel.com]
> Sent: Wednesday, June 10, 2015 4:10 AM
> To: dev@dpdk.org
> Cc: david.marchand@6wind.com; Burakov, Anatoly; Zhang, Helin; Bernal Marin,
> Miguel
> Subject: Re: [dpdk-dev] Headers files with BSD license in kernel
> 
> Including maintainers in CC
> 
> On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > Hi,
> >
> > I'm working on Clear Linux project, and when I was integrating DPDK
> > kernel modules to our kernel I found there are two headers with BSD
> > License
> >
> > rte_pci_dev_feature_defs.h
> > rte_pci_dev_features.h
> >
> > those are included in igb_uio module.
> >
> > Are those licenses correct?
> >
> > Thanks,
> > Miguel
> >

Re: [dpdk-dev] Headers files with BSD license in kernel

[Stephen Hemminger]

On Wed, 10 Jun 2015 00:42:59 +0000
"Zhang, Helin" <helin.zhang@intel.com> wrote:

> Hi Miguel
> 
> My thought is there might be something wrong. Let's see what comments from other experts!
> Thank you very much for the good catch!
> 
> Regards,
> Helin
> 
> > -----Original Message-----
> > From: Miguel Bernal Marin [mailto:miguel.bernal.marin@linux.intel.com]
> > Sent: Wednesday, June 10, 2015 4:10 AM
> > To: dev@dpdk.org
> > Cc: david.marchand@6wind.com; Burakov, Anatoly; Zhang, Helin; Bernal Marin,
> > Miguel
> > Subject: Re: [dpdk-dev] Headers files with BSD license in kernel
> > 
> > Including maintainers in CC
> > 
> > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > Hi,
> > >
> > > I'm working on Clear Linux project, and when I was integrating DPDK
> > > kernel modules to our kernel I found there are two headers with BSD
> > > License
> > >
> > > rte_pci_dev_feature_defs.h
> > > rte_pci_dev_features.h
> > >
> > > those are included in igb_uio module.
> > >
> > > Are those licenses correct?
> > >
> > > Thanks,
> > > Miguel
> > >

You can always escalate a BSD license to GPL, but the other way is not allowed.
Ideally, the language on the file should make it clear that it is dual licensed.
In an ideal world, igb_uio would go away, I am working on that.

Re: [dpdk-dev] Headers files with BSD license in kernel

[Zhang, Helin]

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, June 10, 2015 9:15 AM
> To: Zhang, Helin
> Cc: Miguel Bernal Marin; dev@dpdk.org; Bernal Marin, Miguel
> Subject: Re: [dpdk-dev] Headers files with BSD license in kernel
> 
> On Wed, 10 Jun 2015 00:42:59 +0000
> "Zhang, Helin" <helin.zhang@intel.com> wrote:
> 
> > Hi Miguel
> >
> > My thought is there might be something wrong. Let's see what comments from
> other experts!
> > Thank you very much for the good catch!
> >
> > Regards,
> > Helin
> >
> > > -----Original Message-----
> > > From: Miguel Bernal Marin
> > > [mailto:miguel.bernal.marin@linux.intel.com]
> > > Sent: Wednesday, June 10, 2015 4:10 AM
> > > To: dev@dpdk.org
> > > Cc: david.marchand@6wind.com; Burakov, Anatoly; Zhang, Helin; Bernal
> > > Marin, Miguel
> > > Subject: Re: [dpdk-dev] Headers files with BSD license in kernel
> > >
> > > Including maintainers in CC
> > >
> > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > Hi,
> > > >
> > > > I'm working on Clear Linux project, and when I was integrating
> > > > DPDK kernel modules to our kernel I found there are two headers
> > > > with BSD License
> > > >
> > > > rte_pci_dev_feature_defs.h
> > > > rte_pci_dev_features.h
> > > >
> > > > those are included in igb_uio module.
> > > >
> > > > Are those licenses correct?
> > > >
> > > > Thanks,
> > > > Miguel
> > > >
> 
> You can always escalate a BSD license to GPL, but the other way is not allowed.
> Ideally, the language on the file should make it clear that it is dual licensed.
> In an ideal world, igb_uio would go away, I am working on that.

Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h should be in dual liceses, and rte_pci_dev_features.h should be in GPL license.

Thanks,
Helin

Re: [dpdk-dev] Headers files with BSD license in kernel

[Thomas Monjalon]

2015-06-10 01:20, Zhang, Helin:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > > Hi,
> > > > >
> > > > > I'm working on Clear Linux project, and when I was integrating
> > > > > DPDK kernel modules to our kernel I found there are two headers
> > > > > with BSD License
> > > > >
> > > > > rte_pci_dev_feature_defs.h
> > > > > rte_pci_dev_features.h
> > > > >
> > > > > those are included in igb_uio module.
> > > > >
> > > > > Are those licenses correct?
> > 
> > You can always escalate a BSD license to GPL, but the other way is not allowed.
> > Ideally, the language on the file should make it clear that it is dual licensed.
> > In an ideal world, igb_uio would go away, I am working on that.
> 
> Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h should be in dual
> liceses, and rte_pci_dev_features.h should be in GPL license.

Yes, it is an error from this commit:
	http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88
These definitions were moved from a GPL file so they should keep the GPL header.
Then it is used in EAL:
	http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19
So it must be dual licensed, like for rte_pci_dev_ids.h:
	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_dev_ids.h

Re: [dpdk-dev] Headers files with BSD license in kernel

[Burakov, Anatoly]

> 2015-06-10 01:20, Zhang, Helin:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I'm working on Clear Linux project, and when I was integrating
> > > > > > DPDK kernel modules to our kernel I found there are two
> > > > > > headers with BSD License
> > > > > >
> > > > > > rte_pci_dev_feature_defs.h
> > > > > > rte_pci_dev_features.h
> > > > > >
> > > > > > those are included in igb_uio module.
> > > > > >
> > > > > > Are those licenses correct?
> > >
> > > You can always escalate a BSD license to GPL, but the other way is not
> allowed.
> > > Ideally, the language on the file should make it clear that it is dual
> licensed.
> > > In an ideal world, igb_uio would go away, I am working on that.
> >
> > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h
> > should be in dual liceses, and rte_pci_dev_features.h should be in GPL
> license.
> 
> Yes, it is an error from this commit:
> 	http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88
> These definitions were moved from a GPL file so they should keep the GPL
> header.
> Then it is used in EAL:
> 	http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19
> So it must be dual licensed, like for rte_pci_dev_ids.h:
> 	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/
> rte_pci_dev_ids.h

Agreed, should have been more careful. Should I make the patch to correct this?

Re: [dpdk-dev] Headers files with BSD license in kernel

[Thomas Monjalon]

2015-06-10 09:01, Burakov, Anatoly:
> > 2015-06-10 01:20, Zhang, Helin:
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'm working on Clear Linux project, and when I was integrating
> > > > > > > DPDK kernel modules to our kernel I found there are two
> > > > > > > headers with BSD License
> > > > > > >
> > > > > > > rte_pci_dev_feature_defs.h
> > > > > > > rte_pci_dev_features.h
> > > > > > >
> > > > > > > those are included in igb_uio module.
> > > > > > >
> > > > > > > Are those licenses correct?
> > > >
> > > > You can always escalate a BSD license to GPL, but the other way is not
> > allowed.
> > > > Ideally, the language on the file should make it clear that it is dual
> > licensed.
> > > > In an ideal world, igb_uio would go away, I am working on that.
> > >
> > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h
> > > should be in dual liceses, and rte_pci_dev_features.h should be in GPL
> > license.
> > 
> > Yes, it is an error from this commit:
> > 	http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88
> > These definitions were moved from a GPL file so they should keep the GPL
> > header.
> > Then it is used in EAL:
> > 	http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19
> > So it must be dual licensed, like for rte_pci_dev_ids.h:
> > 	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/
> > rte_pci_dev_ids.h
> 
> Agreed, should have been more careful. Should I make the patch to correct this?

You are welcome :)