From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 76E9B5A9B
 for <dev@dpdk.org>; Wed, 10 Jun 2015 13:07:42 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 10 Jun 2015 04:07:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,587,1427785200"; d="scan'208";a="708505611"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21])
 by orsmga001.jf.intel.com with SMTP; 10 Jun 2015 04:07:39 -0700
Received: by  (sSMTP sendmail emulation); Wed, 10 Jun 2015 12:07:38 +0025
Date: Wed, 10 Jun 2015 12:07:38 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Message-ID: <20150610110738.GB6924@bricha3-MOBL3>
References: <1431428560-25426-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1432289771-12799-7-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432289771-12799-7-git-send-email-pablo.de.lara.guarch@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 06/10] hash: update jhash function with
 the latest available
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 11:07:43 -0000

On Fri, May 22, 2015 at 11:16:07AM +0100, Pablo de Lara wrote:
> Jenkins hash function was developed originally in 1996,
> and was integrated in first versions of DPDK.
> The function has been improved in 2006,
> achieving up to 60% better performance, compared to the original one.
> 
> This patch integrates that code into the rte_jhash library.
> It also updates the precalculated hash values in the unit test,
> as the code now returns different values (expected)
> 
This should be clearly called out in the release notes for 2.1. I don't expect
that too many people are relying on the specific return values from the hash
function, but just in case, we need to call this out.

/Bruce