From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6834E5ABA for ; Fri, 12 Jun 2015 12:37:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 12 Jun 2015 03:37:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,601,1427785200"; d="scan'208";a="742064442" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21]) by fmsmga002.fm.intel.com with SMTP; 12 Jun 2015 03:37:37 -0700 Received: by (sSMTP sendmail emulation); Fri, 12 Jun 2015 11:37:36 +0025 Date: Fri, 12 Jun 2015 11:37:36 +0100 From: Bruce Richardson To: Pablo de Lara Message-ID: <20150612103736.GA10552@bricha3-MOBL3> References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 00/10] update jhash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 10:37:40 -0000 On Wed, Jun 10, 2015 at 04:25:17PM +0100, Pablo de Lara wrote: > Jenkins hash function was developed originally in 1996, > and was integrated in first versions of DPDK. > The function has been improved in 2006, > achieving up to 35% better performance, compared to the original one. > > This patchset updates the current jhash in DPDK, > including two new functions that generate two hashes from a single key. > > It also separates the existing hash function performance tests to > another file, to make it quicker to run, and add new unit tests. > > changes in v6: > - Use RTE_DIM macro, so it saves lines of code > - Correct mistaken performance improvement > - Add deprecated attribute, instead of printing a message calling it > - Add note stating the changes in release notes > > changes in v5: > - Add functional tests (mainly to test that all functions > return the expected hash values) > - Modify range of key sizes to test > - Change order of output for perf tests, so it is clearer > to compare different hash functions for same key size/initial value > - Add new initial value to test in the hash functions > - Fix some errors caught by checkpatch > > changes in v4: > - Simplify key alignment checks > - Include missing x86 arch check > > changes in v3: > > - Update rte_jhash_1word, rte_jhash_2words and rte_jhash_3words > functions > > changes in v2: > > - Split single commit in three commits, one that updates the existing functions > and another that adds two new functions and use one of those functions > as a base to be called by the other ones. > - Remove some unnecessary ifdefs in the code. > - Add new macros to help on the reutilization of constants > - Separate hash function performance tests to another file > and improve cycle measurements. > - Rename existing function rte_jhash2 to rte_jhash_32b > (something more meaninful) and mark rte_jhash2 as > deprecated > Thanks for the all the work, and rework, Pablo. Series Acked-by: Bruce Richardson