From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 5DB8EBDC2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 01:05:11 +0200 (CEST)
Received: by padev16 with SMTP id ev16so21430381pad.0
 for <dev@dpdk.org>; Tue, 16 Jun 2015 16:05:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=KXQNQSrtvwLRVxCuV33tYmeADrkbxugiegLe9xozPB4=;
 b=QIpFm/9tHPWuWs5IrpeEfS6nA5gwFp4dmL0eW9rzzrCEb1zJe9FHD3fxlGXJjavnID
 ZphsWOQHqA/cU3VWk6kam/EIWiEdA0g2/l43pHbo42Oqh9cBBMwNwPyf9LeXr2lje9GU
 iDZMAjzktHniF2ntq2IyTEOZFdnMAndeYcfyoDCjkyepEGhBBw60boUwbMPqyndfTjA1
 bZ39XxpJQK1OpIvl8VOU9NUGDbGe3c/SQcLTZ4UBoB/5c78pNiD73g0xtsqUSOLjVh5X
 oOKm7vn923LNU0CXIxA1RMtjjJ6zetO+1WNwo0VkxoJhWIziUWmxZDcUAuoNditOJizB
 WOwA==
X-Gm-Message-State: ALoCoQnX4ZSTCMU7+k99NCyoIo/wAsPm9VkgWC8oew2oEZohBnEflRnmlUVlaq2aByEmknoeE/J7
X-Received: by 10.70.56.98 with SMTP id z2mr4804914pdp.120.1434495910373;
 Tue, 16 Jun 2015 16:05:10 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ob15sm2504329pdb.40.2015.06.16.16.05.09
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 16 Jun 2015 16:05:10 -0700 (PDT)
Date: Tue, 16 Jun 2015 16:05:12 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20150616160512.03873f22@urahara>
In-Reply-To: <20150616135216.GA9780@bricha3-MOBL3>
References: <1434387073-16951-1-git-send-email-stephen@networkplumber.org>
 <1434387073-16951-2-git-send-email-stephen@networkplumber.org>
 <20150616135216.GA9780@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] pmd_ring: remove deprecated functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2015 23:05:11 -0000

On Tue, 16 Jun 2015 14:52:16 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Mon, Jun 15, 2015 at 09:51:11AM -0700, Stephen Hemminger wrote:
> > From: Stephen Hemminger <shemming@brocade.com>
> > 
> > These were deprecated in 2.0 so remove them from 2.1
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  drivers/net/ring/rte_eth_ring.c           | 55 -------------------------------
> >  drivers/net/ring/rte_eth_ring_version.map |  4 +--
> >  2 files changed, 1 insertion(+), 58 deletions(-)
> >   
> [..snip..]
> > diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map
> > index 8ad107d..5ee55d9 100644
> > --- a/drivers/net/ring/rte_eth_ring_version.map
> > +++ b/drivers/net/ring/rte_eth_ring_version.map
> > @@ -1,9 +1,7 @@
> > -DPDK_2.0 {
> > +DPDK_2.1 {
> >  	global:
> >  
> >  	rte_eth_from_rings;
> > -	rte_eth_ring_pair_attach;
> > -	rte_eth_ring_pair_create;
> >  
> >  	local: *;
> >  };  
> 
> [ABI newbie question] Is this how deprecating a fn is done? We no longer have any DPDK_2.0 
> version listings in the .map file?

Notice the version # changed as well, so linker will generate a new version.
The function was marked deprecated in last version.